Conversation
- AGENTS.md: comments must not restate a rule already in ARCHITECTURE.md (that duplication drifts out of date). - ARCHITECTURE.md: give the createStore paragraph its own "Cross-instance state" subsection, parallel to "Two homes for a side-effect" under "The machine parts". Both are refinements that surfaced while working the shared docs elsewhere; the rest of that work is either substrate-specific or already present here. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
ivanbanov
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why/What
Bringing across the genuinely portable doc refinements that surfaced while working the shared state-machine docs in another worktree. dunky is the source of truth for these files, so most of that work was either substrate-specific or already present here — this PR is only the two deltas that actually improve dunky.
Changes
ARCHITECTURE.md; that duplication just drifts out of date.createStoreparagraph its own Cross-instance state subsection, parallel to Two homes for a side-effect under The machine parts (better structure/TOC).Docs-only, no published-package change, so no changeset.
Considered but not ported
className/asChild, nvm) — don't apply to this engine repo.|_file-tree diagram convention — skipped: dunky's diagrams consistently use+--, and adopting|_half-way would contradict existing trees (the source repo doesn't follow it either). Happy to do a full sweep if we want that style.Issues
—
🤖 Generated with Claude Code