From<proc_macro::Span> is missing for proc_macro2::Span when DOCS_RS=1 - #501
Closed
wtdcode wants to merge 2 commits into
Closed
From<proc_macro::Span> is missing for proc_macro2::Span when DOCS_RS=1#501wtdcode wants to merge 2 commits into
From<proc_macro::Span> is missing for proc_macro2::Span when DOCS_RS=1#501wtdcode wants to merge 2 commits into
Conversation
Author
|
CI failure seems not relevant to my changes. |
wtdcode
added a commit
to AFLplusplus/LibAFL
that referenced
this pull request
May 17, 2025
track: dtolnay/proc-macro2#501
wtdcode
force-pushed
the
impl-proc-macro-span
branch
from
May 17, 2025 16:52
d8ca892 to
1dbb2a7
Compare
Author
|
|
wtdcode
added a commit
to AFLplusplus/LibAFL
that referenced
this pull request
May 18, 2025
* fix ci track: dtolnay/proc-macro2#501 * format toml * fix typo * Use nightly for libafl_frida * Install nightly for splitter * Use dtolnay/rust-toolchain@nightly * install ca-certificates
Owner
|
Since #511 proc-macro2's build no longer looks at $DOCS_RS. |
rmalmain
pushed a commit
to LibAFLminusminus/LibAFLminusminus
that referenced
this pull request
Apr 27, 2026
* fix ci track: dtolnay/proc-macro2#501 * format toml * fix typo * Use nightly for libafl_frida * Install nightly for splitter * Use dtolnay/rust-toolchain@nightly * install ca-certificates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello, I narrowed down this error when debugging our CI: https://github.com/AFLplusplus/LibAFL/actions/runs/15085325118/job/42407219490#step:5:180
Generally, as illustrated in GnomedDev/proc-macro-error-2#12 (comment) , when
DOCS_RS=1,proc-macro2will miss the implementationFrom<proc_macro::Span>forproc_macro2::Span(existing inwrapper.rs), causing issues to downstreams.Note a minimum reproduction was also attached in the issue above.
This PR fixes it by adding the implementation when
DOCS_RS=1and thuswrap_proc_macrois not defined. I'm not 100% confident this is the correct place for the fix to go so any inputs are highly welcome =).