Feature #584 resolve links - #585
Open
jprestop wants to merge 44 commits into
Open
Conversation
…new repo dtcenter/metplus-action-linkcheck
23 tasks
JohnHalleyGotway
self-requested a review
July 29, 2026 18:55
JohnHalleyGotway
approved these changes
Jul 29, 2026
JohnHalleyGotway
left a comment
Contributor
There was a problem hiding this comment.
I approve of these changes and note the following:
- All GHA tests pass, including the link checker, with no errors or warnings flagged.
- Applied consistent capitalization in section titles.
- Corrected some METplus URLs.
- Updated the list of URLs that should be ignored in
conf.pydue to a variety of issues.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Testing
Describe testing already performed for these changes:
Ran
sphinx-build -b linkcheck . _build/linkcheckllocally and verified that all of the link check problems were resolved.Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Ensure all tests pass
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
Do these changes include sufficient testing updates? [Yes]
Will this PR result in changes to the test suite? [No]
If yes, describe the new output and/or changes to the existing output:
Do these changes introduce new SonarQube findings? [No]
If yes, please describe:
Please complete this pull request review by [Prior to the release].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases