Skip to content

Feature #584 resolve links - #585

Open
jprestop wants to merge 44 commits into
developfrom
feature_584_resolve_links
Open

Feature #584 resolve links#585
jprestop wants to merge 44 commits into
developfrom
feature_584_resolve_links

Conversation

@jprestop

Copy link
Copy Markdown
Contributor

Pull Request Testing

  • Describe testing already performed for these changes:

    Ran sphinx-build -b linkcheck . _build/linkcheckl locally and verified that all of the link check problems were resolved.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Ensure all tests pass

  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]

  • Do these changes include sufficient testing updates? [Yes]

  • Will this PR result in changes to the test suite? [No]

    If yes, describe the new output and/or changes to the existing output:

  • Do these changes introduce new SonarQube findings? [No]

    If yes, please describe:

  • Please complete this pull request review by [Prior to the release].

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Jul 29, 2026
@jprestop jprestop moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development Jul 29, 2026
@jprestop jprestop added this to the METplotpy-13.0.0 milestone Jul 29, 2026
@jprestop jprestop linked an issue Jul 29, 2026 that may be closed by this pull request
23 tasks
@JohnHalleyGotway JohnHalleyGotway changed the title Feature 584 resolve links Feature #584 resolve links Jul 29, 2026
@JohnHalleyGotway
JohnHalleyGotway self-requested a review July 29, 2026 18:55

@JohnHalleyGotway JohnHalleyGotway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes and note the following:

  • All GHA tests pass, including the link checker, with no errors or warnings flagged.
  • Applied consistent capitalization in section titles.
  • Corrected some METplus URLs.
  • Updated the list of URLs that should be ignored in conf.py due to a variety of issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Resolve the issues discovered by the automated linkcheck

2 participants