Skip to content

Feature dtcenter/METplus#3247 link check - #583

Merged
jprestop merged 9 commits into
developfrom
feature_METplus3247_link_check
Jul 29, 2026
Merged

Feature dtcenter/METplus#3247 link check#583
jprestop merged 9 commits into
developfrom
feature_METplus3247_link_check

Conversation

@jprestop

Copy link
Copy Markdown
Contributor

This PR is the same as this PR in the METplus repository, Feature #3247 link check #3325, minus the Contributor's Guide documentation. See the METplus PR for further details.

Pull Request Checklist

See the METplus Workflow for details.

  • Add any new Python packages to the METplus Components Python Requirements table.
  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

@jprestop jprestop added this to the METplotpy-13.0.0 milestone Jul 14, 2026
@github-project-automation github-project-automation Bot moved this to 🩺 Needs Triage in METplus-13.0 Development Jul 14, 2026
@jprestop jprestop moved this from 🩺 Needs Triage to 🔎 In review in METplus-13.0 Development Jul 14, 2026
@jprestop
jprestop changed the base branch from main_v3.2 to develop July 14, 2026 20:53
@JohnHalleyGotway JohnHalleyGotway changed the title Feature METplus3247 link check Feature dtcenter/METplus#3247 link check Jul 27, 2026

@JohnHalleyGotway JohnHalleyGotway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jprestop I see many warnings on other GHA tests for this PR in:
https://github.com/dtcenter/METplotpy/pull/583/checks

Can you please take a look at them and either resolve the warnings or document in the body of the PR what's going on with the failures?

@jprestop

Copy link
Copy Markdown
Contributor Author

@JohnHalleyGotway I don't fully understand the testing going on here. I see a "Python Tests / build (3.12, develop) (pull request)" and a "Python Tests / build (3.12, feature_METplus3247_link_check) (pull request)" along with the same for "3.14". Prior to my last commit, "Attempt to resolve unrelated python test errors" all of these were failing, but now only the "develop" versions are failing. The SonarQube test had also failed, but is now ok.
Can you explain this set up of tests? Since the tests labeled with feature_METplus3247_link_check are now passing this PR is ok to approve?

@JohnHalleyGotway JohnHalleyGotway left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve of these changes. I do see there are still issues with the pytests, but those issues lie in the develop branch rather than your feature branch. So hopefully these changes will actually resolve those failures.

Thanks for your work on this.

@jprestop
jprestop merged commit 054aeb3 into develop Jul 29, 2026
11 of 14 checks passed
@github-project-automation github-project-automation Bot moved this from 🔎 In review to 🏁 Done in METplus-13.0 Development Jul 29, 2026
@jprestop
jprestop deleted the feature_METplus3247_link_check branch July 29, 2026 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🏁 Done

Development

Successfully merging this pull request may close these issues.

2 participants