Feature dtcenter/METplus#3247 link check - #583
Conversation
…new repo dtcenter/metplus-action-linkcheck
JohnHalleyGotway
left a comment
There was a problem hiding this comment.
@jprestop I see many warnings on other GHA tests for this PR in:
https://github.com/dtcenter/METplotpy/pull/583/checks
Can you please take a look at them and either resolve the warnings or document in the body of the PR what's going on with the failures?
|
@JohnHalleyGotway I don't fully understand the testing going on here. I see a "Python Tests / build (3.12, develop) (pull request)" and a "Python Tests / build (3.12, feature_METplus3247_link_check) (pull request)" along with the same for "3.14". Prior to my last commit, "Attempt to resolve unrelated python test errors" all of these were failing, but now only the "develop" versions are failing. The SonarQube test had also failed, but is now ok. |
JohnHalleyGotway
left a comment
There was a problem hiding this comment.
I approve of these changes. I do see there are still issues with the pytests, but those issues lie in the develop branch rather than your feature branch. So hopefully these changes will actually resolve those failures.
Thanks for your work on this.
This PR is the same as this PR in the METplus repository, Feature #3247 link check #3325, minus the Contributor's Guide documentation. See the METplus PR for further details.
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: Coordinated METplus-X.Y Support project for bugfix releases or METplotpy-X.Y.Z Development project for official releases