Allow maps and sets in paths - #36
Open
dscarpetti wants to merge 9 commits into
Open
Conversation
Owner
Author
|
@Frozenlock, per #34, I reserved hex codes 0xa0-0xaf for future use. Do you have any additional thoughts before this gets merged? |
Contributor
|
Unfortunately, looking deeper into this I don't think this implementation works. The (cpath/encode {:a 1, {:k :b} 2})
;=> "¢ ia\01_001x1\0\0 ¢ ik\0ib\0\0\01_001x2\0\0\0"
(cpath/encode {{:k :b} 2, :a 1})
;=> "¢ ¢ ik\0ib\0\0\01_001x2\0\0 ia\01_001x1\0\0\0"
(def db (c/open-database! "test-db"))
(c/destroy-database! "test-db")
(let [k1 {:a 1, {:k :b} 2}
k2 {{:k :b} 2, :a 1}]
(c/assoc-at! db [k1] "test")
(c/get-at! db [k2]))
;; => nil
(let [k1 {:a 1, {:k :b} 2}
k2 {{:k :b} 2, :a 1}]
(-> (assoc-in {} [k1] "test")
(get-in [k2])))
;; => "test"
|
added 6 commits
June 8, 2025 11:03
Owner
Author
|
Good catch. I think that issue is now fixed. I added a tests in codax.pathwise-test for the specific case above and some fuzz testing that randomizes map orderings. |
Contributor
|
As far as I can tell, this is fixed and works well. Time for a new release? 😀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #34