report/main_loop: don't launch kateri in native-renderer mode - #35
Open
drserajames wants to merge 1 commit into
Open
report/main_loop: don't launch kateri in native-renderer mode#35drserajames wants to merge 1 commit into
drserajames wants to merge 1 commit into
Conversation
…ected main_loop() spawned KateriTask + SocketServerTask for any command not marked @no_kateri, regardless of AE_REPORT_MAP_RENDERER. So with the native renderer (the default) a report run — `export`, `serum_coverage_export`, … — still launched the kateri app, which then sat idle (native ignores it). On a normal Mac that goes unnoticed; where the unix socket can't bind it hard-fails. Guard the launch on `not native_selected()` so native mode runs with NO kateri process at all — realising the P2 "no kateri launch" goal end-to-end. The opt-in kateri backend (AE_REPORT_MAP_RENDERER=kateri) still launches it. Surfaced by a full end-to-end report.pdf run. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Don't launch kateri when the native renderer is selected
main_loop()spawnedKateriTask+SocketServerTaskfor any command not marked@no_kateri, regardless ofAE_REPORT_MAP_RENDERER. So with the native renderer (now the default), a report run —export,serum_coverage_export, … — still launched the kateri app, which then sat idle because the native renderer ignores it. On a normal Mac this goes unnoticed (kateri launches, connects, does nothing); where the unix socket can't bind, the run hard-fails before rendering.This means the P2 "no kateri process" goal was only realised inside
export's body (styled.ace / sig-page-mapi round-trips replaced by native code, commit90f9051) — the app was still launched bymain_loop.Fix: guard the kateri-task launch on
not native_selected(), so native mode runs a report with no kateri process at all. The opt-in kateri backend (AE_REPORT_MAP_RENDERER=kateri) still launches it, and@no_katericommands are unaffected.Surfaced by a full end-to-end
report.pdfacceptance run (which produced a kateri-free 36-page report, 32/36 pages pixel-identical to the kateri baseline, the rest the expected native-vs-kateri AA floor). WHO-data gate clean.