Fix impacket script path false positive on library module#98
Merged
Conversation
secretsdump.py exists as an internal library module in site-packages/impacket/examples/ (no shebang, not a CLI tool), causing _get_impacket_script_path() to return a directory with no CLI scripts. GetNPUsers.py is CLI-only and never has a library twin. Bump to 2.1.6. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_get_impacket_script_path()usedsecretsdump.pyas sentinel to validate a candidate directory. Butsecretsdump.pyexists as an internal library module insite-packages/impacket/examples/(no shebang, not a CLI script), so the check passed and the function returned a directory containing no CLI scripts. Every impacket tool then failed withFileNotFoundError.Fixed
secretsdump.pytoGetNPUsers.py— a CLI-only script with no library module twin