Skip to content

feat: define Codex review contract and reject unsupported agents - #21

Merged
douglasjarquin merged 9 commits into
mainfrom
codex/made-remaining-issues
Aug 18, 2026
Merged

feat: define Codex review contract and reject unsupported agents#21
douglasjarquin merged 9 commits into
mainfrom
codex/made-remaining-issues

Conversation

@douglasjarquin

@douglasjarquin douglasjarquin commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Closes #4

Summary

  • Adds a Made-owned, versioned Codex review prompt and strict structured-output contract with trusted base, candidate input/output identity, exact diff command, scope, taxonomy, exclusions, bounded task/output/execution, and review evidence.
  • Requires explicit candidate-diff inspection, exact affected paths, controlled auto-fix policy, and fail-closed malformed, unknown-kind, missing-field, and invented-invocation rejection.
  • Verifies trusted-base availability in a detached review copy and preserves read-only Codex execution, no-write/no-merge boundaries, and supported-agent truthfulness.
  • Rejects unsupported agents before pipeline stages, removes Claude from capabilities and generated skill text, and resolves candidate output identity from the actual reviewed HEAD before evidence.

Validation

  • Final source SHA: 84aec895a410b72331d06817125e0fc4ff1fcbee.
  • Trusted base SHA: cdf0b40cc5a07790cb9d512b4b931b8df19145fa.
  • GOTOOLCHAIN=local go build ./... passed.
  • GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false GOTOOLCHAIN=local go test ./... passed.
  • GIT_CONFIG_COUNT=1 GIT_CONFIG_KEY_0=commit.gpgsign GIT_CONFIG_VALUE_0=false GOTOOLCHAIN=local go test -race -shuffle=on -count=1 ./... passed.
  • GOTOOLCHAIN=local go vet ./... passed.
  • make lint passed with 0 issues.
  • Repository LSP diagnostics reported 0 errors and 0 diagnostics.
  • made capabilities --json reports only codex.

Native Codex smoke

  • /opt/homebrew/bin/codex codex-cli 0.147.0 is authenticated with ChatGPT credentials.
  • A disposable safe-to-unsafe repository was reviewed with codex exec --cd <review> --json --output-schema <schema> --sandbox read-only --ephemeral -.
  • The bounded retry exited 0 with a schema-valid blocking finding naming check.sh and the exact affected path.
  • Receipt: /tmp/made-issue4-final-receipt-84aec89.md.

Hosted delivery and custody

@douglasjarquin
douglasjarquin merged commit e2550c8 into main Aug 18, 2026
1 check passed
@douglasjarquin
douglasjarquin deleted the codex/made-remaining-issues branch August 18, 2026 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Define a substantive Codex review contract and reject unsupported agents

1 participant