Revert "Detect and report outdated Maestro URLs" - #6572
Merged
Conversation
This reverts commit 266e579.
dkurepa
approved these changes
Aug 12, 2026
premun
enabled auto-merge (squash)
August 12, 2026 13:46
Contributor
There was a problem hiding this comment.
Pull request overview
This PR reverts #6555, removing the DARC behavior that detected/outdated Maestro (BAR) base URIs and warned users, along with the associated tests and documentation updates.
Changes:
- Removed the “warn if using non-default/outdated Maestro URI” logic from DARC options initialization.
- Removed unit tests covering Maestro URI warning behavior.
- Removed corresponding documentation text describing the warning behavior.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/Darc/Microsoft.DotNet.Darc.Tests/Operations/OperationsTests.cs | Removes tests that validated warning/no-warning behavior for default/outdated Maestro URIs. |
| src/Microsoft.DotNet.Darc/Darc/Options/CommandLineOptions.cs | Reverts settings-initialization warning logic and simplifies console logging configuration. |
| docs/Darc.md | Removes documentation describing the non-default/outdated Maestro URI warning behavior. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
127
to
131
| services.AddLogging(b => b | ||
| .AddConsole(o => | ||
| { | ||
| o.FormatterName = CompactConsoleLoggerFormatter.FormatterName; | ||
| // Route warnings and above to stderr so they don't corrupt machine-readable | ||
| // output (e.g. `--output-format json`) written to stdout. | ||
| o.LogToStandardErrorThreshold = LogLevel.Warning; | ||
| }) | ||
| .AddConsole(o => o.FormatterName = CompactConsoleLoggerFormatter.FormatterName) | ||
| .AddConsoleFormatter<CompactConsoleLoggerFormatter, SimpleConsoleFormatterOptions>() | ||
| .SetMinimumLevel(level) | ||
| .AddFilter("Microsoft.DotNet.DarcLib.VirtualMonoRepo." + nameof(VmrPatchHandler), LogLevel.Warning)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #6555