Skip to content

Feature/New landing page#10

Closed
OStefan2001 wants to merge 1 commit into
developfrom
stefan-dev
Closed

Feature/New landing page#10
OStefan2001 wants to merge 1 commit into
developfrom
stefan-dev

Conversation

@OStefan2001

Copy link
Copy Markdown
Collaborator

Responisve menu, dark-mode/light-mode, png images converted to svg for dark/light mode

@OStefan2001 OStefan2001 requested a review from alexmerlin July 15, 2026 07:24

@alexmerlin alexmerlin left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, we should not keep the old WP media file structure (e.g.: public/uploads/2025/01/icon_feed-d.svg)

Comment thread src/App/templates/layout/default.html.twig
<p>The error looks similar to the image below:</p>

<figure>
<img src="/uploads/2019/04/Screenshot-2019-04-06-at-15.03.21-1024x165-1-1024x165.png" alt="">

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please include this as a Twig asset.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing empty line at the end of the file.

Comment on lines +49 to +54
<p class="lede">
The Dotkernel Headless Platform is made up of Open Source components aimed at
businesses that need custom solutions. It supports microservices, as well as
enterprise-grade APIs. Its modern, future-proof architecture is based on
middleware and PSRs.
</p>

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<p class="lede">
The Dotkernel Headless Platform is made up of Open Source components aimed at
businesses that need custom solutions. It supports microservices, as well as
enterprise-grade APIs. Its modern, future-proof architecture is based on
middleware and PSRs.
</p>
<p class="lede">
The Dotkernel Headless Platform is made up of Open Source components aimed at businesses that need custom solutions.
It supports microservices, as well as enterprise-grade APIs. Its modern, future-proof architecture is based on middleware and PSRs.
</p>

It is recommended to keep one sentence per line.
Reason: when reviewing it makes more sense to tell the developer to "fix sentence on line X" when the line contains one sentence only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants