feat(meowbot): add Reloader annotation-surface plumbing to the Deployment - #2
Merged
Dotablaze merged 1 commit intoAug 7, 2026
Conversation
podAnnotations only reaches the pod template's metadata, but Reloader's secret.reloader.stakater.com/reload annotation must live on the Deployment object's own metadata for the controller to see it. Add a deploymentAnnotations values hook and set it in both env overrides, listing each Deployment's distinct Secret names sourced via env[].valueFrom.secretKeyRef.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
JDWLABS-310 (follow-up to JDWLABS-291 / ADR 0016):
charts/meowbot/templates/deployment.yamlonly exposedpodAnnotations, which lands on the pod template'smetadata, not the Deployment object's ownmetadata. Stakater Reloader'ssecret.reloader.stakater.com/reloadopt-in annotation must live on the Deployment itself, so the chart had no hook to reach it.deploymentAnnotationsvalues hook tocharts/meowbot/templates/deployment.yaml, rendered directly under the Deployment's top-levelmetadata(sibling ofspec), separate from the existing pod-templatepodAnnotationsblock.secret.reloader.stakater.com/reloadinvalues-non.yamlandvalues-prd.yaml, listing the distinct Secret names each environment's Deployment reads viaenv[].valueFrom.secretKeyRef— re-verified live against the current chart rather than trusting the stale count from the original sweep:meowbot-pg-non,meowbot-nonmeowbot-pg-prd,meowbot-prdversion(0.1.0 -> 0.2.0) for the template change.Once Reloader is live cluster-wide (JDWLABS-291), these two Deployments (
dotablaze-tech-meowbot-non/dotablaze-tech-meowbot-prd) will restart automatically on Vault-driven secret rotation instead of silently serving stale credentials.Test plan
helm lint charts/meowbot— 0 chart(s) failedhelm template(viartk proxyto avoid truncated output) for bothvalues-non.yamlandvalues-prd.yaml— confirmed the annotation renders at.metadata.annotationson the Deployment, not.spec.template.metadata.annotations