Update to goodgame for the new rapidapi nonsesne - #1
Open
bryburgess wants to merge 4 commits into
Open
Conversation
…ly different than v1. Updated with the param requirement and new subsetting calls since getting the api keys now gives you V2 by default.
… and cleaning up variable names.
most recent game is no longer last item returned in api call, tinkering with the loop to more explicitly call most recent finished game
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON architecture in the V2 rapidapi api-nba data is slightly different than v1, and it now loans that for users by default when they request api keys (like I did this afternoon setting this up locally). Updated with the params requirement and new subsetting calls, and created 'latest_game' before the loop to avoid some errors.
Neat script though! Getting it to work on my end was some fun tinkering around this afternoon.
P.S. Ignore the datetime import on line 3. I was trying to mess around with some ways to get both scores and standings from one high-level call, and the API needed a date in the params for that.