Skip to content

chore: add license headers to accesscontrol files#592

Merged
joe0BAB merged 1 commit into
mainfrom
secrets-engine-releaser-bump-20260717-143541-450b7546-secrets-engine
Jul 17, 2026
Merged

chore: add license headers to accesscontrol files#592
joe0BAB merged 1 commit into
mainfrom
secrets-engine-releaser-bump-20260717-143541-450b7546-secrets-engine

Conversation

@joe0BAB

@joe0BAB joe0BAB commented Jul 17, 2026

Copy link
Copy Markdown
Collaborator

No description provided.

@joe0BAB
joe0BAB marked this pull request as ready for review July 17, 2026 14:43
Signed-off-by: Johannes Großmann <grossmann.johannes@t-online.de>
@joe0BAB
joe0BAB force-pushed the secrets-engine-releaser-bump-20260717-143541-450b7546-secrets-engine branch from bcf478c to 4649fea Compare July 17, 2026 14:44

@docker-agent docker-agent left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assessment: 🟢 APPROVE

This PR adds Apache 2.0 license headers to four access-control source files — a purely mechanical change with no functional impact. No logic, security, or correctness problems were introduced.


MINOR finding: Missing trailing newline at end of file (all 4 files)

All four modified files now lack a trailing newline. The diff shows \ No newline at end of file on the last + line of each file after the license header was prepended:

  • x/api/accesscontrol/accesscontrol.go (last line: })
  • x/api/accesscontrol/accesscontrol_darwin.go (last line: ))
  • x/api/accesscontrol/accesscontrol_linux.go (last line: })
  • x/api/accesscontrol/accesscontrol_windows.go (last line: ))

POSIX defines a text file as ending with a newline. While Go tooling handles missing trailing newlines gracefully, some linters and diff tools may flag this. A newline was present before this PR (the original files end with } or ) followed by \n); the license-header prepend process appears to have stripped it. Adding a blank final line to each file would restore the trailing newline.

@joe0BAB
joe0BAB merged commit 6209391 into main Jul 17, 2026
11 checks passed
@joe0BAB
joe0BAB deleted the secrets-engine-releaser-bump-20260717-143541-450b7546-secrets-engine branch July 17, 2026 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants