Skip to content

commands: reload nodes after inspect --bootstrap #4038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
locker95 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

commands: reload nodes after inspect --bootstrap #4038

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions commands/inspect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,14 +47,14 @@ func runInspect(ctx context.Context, dockerCli command.Cli, in inspectOptions) e
imageVerifier := policy.DefaultImageVerifier(confutil.NewConfig(dockerCli))
nodes, err := b.LoadNodes(timeoutCtx, builder.WithData(), builder.WithImageVerifier(imageVerifier))
if in.bootstrap {
var ok bool
ok, err = b.Boot(ctx)
_, err = b.Boot(ctx)
if err != nil {
return err
}
if ok {
nodes, err = b.LoadNodes(timeoutCtx, builder.WithData(), builder.WithImageVerifier(imageVerifier))
}
// Always reload. Boot() returns ok=false when it had nothing to start
// (already running, or the first LoadNodes never got DriverInfo).
// Skipping the reload leaves inspect printing stale "inactive" nodes.
nodes, err = b.LoadNodes(timeoutCtx, builder.WithData(), builder.WithImageVerifier(imageVerifier))
}

w := tabwriter.NewWriter(os.Stdout, 0, 0, 1, ' ', 0)
Expand Down