release: prep v1.5.2 — ⚠️ TAG HELD pending the second ultrareview - #154
Merged
Conversation
Version strings bumped via bin/prep-release.sh. Changelog derived from the `v1.5.1..main` DIFF, which is one shippable file: includes/class-config.php (+46/-3), the normalizing-equivalent-key dedupe from #153.⚠️ DO NOT TAG YET. A second ultrareview is still running in another session and may confirm further bugs. If it does, they belong in THIS patch: tagging now would either ship a fix whose changelog omits its siblings, or force a v1.5.3 days later. v1.4.0's gate 8 caught a changelog overclaim by diffing the real commits — the same discipline says do not finalise the changelog until the commit set is. Two changelog entries, both from the one fix, split because they are different audiences: - The general one: an override could silently stop applying when a single save carried two spellings of the same item's address. Written to name the symptom a user would actually notice — a rename or visibility rule that stops working while still showing in settings — rather than the mechanism. - The authorization one: it also closes a way for a saver who cannot list users to undo an administrator's per-person rule. Stated plainly, with the cosmetic-only guarantee restated, because that is the claim people will check. NOT framed as a security release. Hiding is cosmetic: no capability was granted or removed and the page stayed URL-reachable throughout. Same framing as 1.4.1. Also riding along, not changelog material: the readme listing copy rewritten in #152 (D4 non-autoloaded differentiator, tags, description). It publishes with the release but is directory copy, not plugin behaviour. Upgrade Notice is 271 chars (Plugin Check limit 300). Gate (Docker-free lanes): unit 167/167 (223 assertions), WPCS clean, PHPStan 0, doc-links clean. Integration/e2e ran green on #153 and re-run here in CI. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version bump + changelog for the patch. The tag is deliberately held — see below.
A second ultrareview is still running in another session and may confirm further bugs. If it does, they belong in this patch. Tagging now would either ship a fix whose changelog omits its siblings, or force a v1.5.3 days later.
v1.4.0's gate 8 caught a changelog overclaim by diffing the real commits. The same discipline says don't finalise the changelog until the commit set is final. This repo has held a tag for exactly this reason before, and the hold was correct that time too.
What clears it: the other review completing, and either no confirmed findings, or their fixes merged here and folded into the 1.5.2 changelog.
Merging this PR is fine whenever you like — it's the tag that's held.
What's in it
Diffed
v1.5.1..mainrather than trusting the commit list. One shippable file:includes/class-config.phpChangelog decisions
Two entries from one fix, split because they're different audiences:
Not framed as a security release. Hiding is cosmetic — no capability was granted or removed, and the affected page stayed URL-reachable throughout for anyone allowed to open it. Same framing as 1.4.1.
Riding along, not changelog material: the readme listing copy rewritten in #152 (D4 non-autoloaded differentiator, tags, description). It publishes with the release, but it's directory copy, not plugin behaviour.
Upgrade Notice is 271 chars (Plugin Check limit 300).
Gate
Docker-free lanes green locally: unit 167/167 (223 assertions), WPCS clean, PHPStan 0, doc-links clean. Integration + e2e ran green on #153 and re-run here in CI.
When the tag does happen
v1.5.2 will be the first release through the new deploy gate. Pushing the tag builds and publishes the GitHub Release, then the deploy job pauses for your approval on the
wordpress-orgenvironment before anything reaches WordPress.org. It's also the first real test of whether theworkflow_callwiring fires at all — the deploy-trigger todo stays open until it does.🤖 Generated with Claude Code