Support helmfile template functions - #21
Draft
DanielHabenicht wants to merge 2 commits into
Draft
Conversation
Helmfile value files use template functions beyond Helm/Sprig (env, requiredEnv, exec, readFile, fetchSecretValue, ...), which were reported as "function ... not defined" by validateTemplateSyntax. Add helmfileFuncMap() registering stubs for those functions on top of helmFuncMap(), and a helmfile validation mode enabled automatically for .gotmpl files or explicitly via --helmfile (needed for stdin). Coverage is a real template fixture (templates_test/) formatting a .gotmpl values file that uses env/requiredEnv; the stdin path selects helmfile mode from the input extension, exercising validation too. Fixes digitalstudium#16. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
Author
|
I don't know whether the extra flags are useful nor needed. If we go with the one tool approach, we could also just add the functions to the map and skip the extra arguments/flags |
Owner
Let's skip the extra arguments please |
Drop the --helmfile flag and .gotmpl auto-detection; merge helmfile's extra template functions (env, requiredEnv, exec, readFile, ...) into helmFuncMap so helmfmt validates and formats helmfile files by default. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Contributor
updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helmfile value files use template functions beyond Helm/Sprig (env, requiredEnv, exec, readFile, fetchSecretValue, ...), which were reported as "function ... not defined" by validateTemplateSyntax.
Add helmfileFuncMap() registering stubs for those functions on top of helmFuncMap(), and a helmfile validation mode enabled automatically for .gotmpl files or explicitly via --helmfile (needed for stdin).
Fixes #16.