Skip to content

fix(gore-as): remap prepared static names - #91

Merged
dh0er merged 1 commit into
mainfrom
codex/mod-manager-v1-staticnames
Aug 18, 2026
Merged

fix(gore-as): remap prepared static names#91
dh0er merged 1 commit into
mainfrom
codex/mod-manager-v1-staticnames

Conversation

@dh0er

@dh0er dh0er commented Aug 18, 2026

Copy link
Copy Markdown
Owner

Summary

  • distinguish raw and prepared StaticNames operand spaces during the loadout-wide remap
  • preserve pristine indices and resolve private prepared rows as base_count + local_row
  • reject missing prepared rows without weakening the raw compile/extract path

Validation

  • cargo test -p gore-as loadout_second_pass_ -- --nocapture (2 passed)
  • full cargo test -p gore-as (323 passed, 13 ignored, integrations passed)
  • real Shipping-cache Manager composition completed after the fix
  • live Viper dialog rendered [Gore probe] UI fixture; UE4SS logged RENDER_PASS exact_count=1
  • independent read-only diff review: clean

The real installation was restored afterward to its byte-exact four-mod baseline; no test package remains deployed.


Note

Medium Risk
Touches core cache remap planning for loadout composition; wrong static-name resolution could break composed modules, but the change is scoped behind the loadout path with explicit error handling and tests.

Overview
Fixes StaticNames remapping when a module has already been prepared against a pristine base and bytecode operands use absolute indices (pristine_count + local_row) rather than indices into the mini’s compact T6 table.

finish_new_symbol_remap takes a prepared_static_names flag: the loadout plan path uses new plan_prepared_static_names, which keeps pristine indices unchanged and maps private prepared rows via base.static_names.len() + local_row; the raw remap_module_allow_new path still uses plan_static_names.

Tests cover a successful loadout second pass with a prepared absolute index and RemapError::MissingStaticName when the referenced prepared row is absent.

Reviewed by Cursor Bugbot for commit 6393c79. Bugbot is set up for automated code reviews on this repo. Configure here.

Prepared minis address private T6 rows after the pristine pool. Resolve those absolute operands in the loadout pass while keeping raw minis local-indexed.
@dh0er

dh0er commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Already looking forward to the next diff.

Reviewed commit: 6393c7975a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dh0er

dh0er commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@dh0er

dh0er commented Aug 18, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 6393c79. Configure here.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. More of your lovely PRs please.

Reviewed commit: 6393c7975a

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dh0er
dh0er merged commit cab5caa into main Aug 18, 2026
2 checks passed
@dh0er
dh0er deleted the codex/mod-manager-v1-staticnames branch August 18, 2026 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant