fix(gore-as): remap prepared static names - #91
Conversation
Prepared minis address private T6 rows after the pristine pool. Resolve those absolute operands in the loadout pass while keeping raw minis local-indexed.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@codex review |
|
@cursor review |
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit 6393c79. Configure here.
|
Codex Review: Didn't find any major issues. More of your lovely PRs please. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
base_count + local_rowValidation
cargo test -p gore-as loadout_second_pass_ -- --nocapture(2 passed)cargo test -p gore-as(323 passed, 13 ignored, integrations passed)[Gore probe] UI fixture; UE4SS loggedRENDER_PASS exact_count=1The real installation was restored afterward to its byte-exact four-mod baseline; no test package remains deployed.
Note
Medium Risk
Touches core cache remap planning for loadout composition; wrong static-name resolution could break composed modules, but the change is scoped behind the loadout path with explicit error handling and tests.
Overview
Fixes StaticNames remapping when a module has already been prepared against a pristine base and bytecode operands use absolute indices (
pristine_count + local_row) rather than indices into the mini’s compact T6 table.finish_new_symbol_remaptakes aprepared_static_namesflag: the loadout plan path uses newplan_prepared_static_names, which keeps pristine indices unchanged and maps private prepared rows viabase.static_names.len() + local_row; the rawremap_module_allow_newpath still usesplan_static_names.Tests cover a successful loadout second pass with a prepared absolute index and
RemapError::MissingStaticNamewhen the referenced prepared row is absent.Reviewed by Cursor Bugbot for commit 6393c79. Bugbot is set up for automated code reviews on this repo. Configure here.