Skip to content

fix(manager): recover interrupted mutations - #89

Merged
dh0er merged 1 commit into
mainfrom
codex/mod-manager-v1-interrupted-apply-recovery
Aug 17, 2026
Merged

fix(manager): recover interrupted mutations#89
dh0er merged 1 commit into
mainfrom
codex/mod-manager-v1-interrupted-apply-recovery

Conversation

@dh0er

@dh0er dh0er commented Aug 17, 2026

Copy link
Copy Markdown
Owner

Summary

  • recover abandoned Manager Apply, reapply, Reset, and Undeploy operations from durable, operation-bound state
  • keep active compiler work and ambiguous ownership blocked; require an exact root/report/action/token plus user confirmation in the GUI
  • bind locks, scratch data, backups, live files, and UE4SS trees to exact filesystem identities
  • add real process-termination coverage for transaction, publication, recovery, and cleanup windows
  • keep every mod and script on the same content- and target-based validation path

Verification

  • cargo test -p gore-as -p gore-mod -p gore-ffi -p gore
  • Windows gore-mod: 499 passed, 15 ignored
  • Windows hard-kill matrix: 22 passed, 1 worker ignored
  • Flutter Mod Manager: 284 passed; flutter analyze clean
  • WSL gore-mod: 509 passed, 5 ignored
  • WSL hard-kill matrix: 19 passed, 1 worker ignored
  • two independent final diff reviews: clean

No real game installation, game process, save, tag, release, or package publication was touched.


Note

Medium Risk
Changes how the GUI mutates game installs during recovery, but native re-validates root and guard id and the UI gates on token, generation, and user confirmation.

Overview
Adds a confirmed recovery path in Mod Manager when setup preflight reports a clearly interrupted Manager apply/undeploy, wired to native mgr_recover_install_v1 with an opaque guard id from preflight.

Preflight now exposes recover_manager_mutation only when action_token is present; the banner offers Recover with a confirmation dialog, then reloads library, status, conflicts, and preflight and shows a localized outcome (busy, restored pristine, compile help needed, etc.). Deployment recovery from status details is tightened so Recover appears only when the current preflight generation still authorizes recover_deployment, avoiding stale undeploy-all when the finding has moved to manager-mutation recovery.

Core bootstrap requires the new FFI command; README documents the flow and warns against manual lock deletion.

Reviewed by Cursor Bugbot for commit ee774c5. Bugbot is set up for automated code reviews on this repo. Configure here.

Bind abandoned Manager operations to durable transaction state and filesystem identities so recovery restores the pre-apply state without guessing or deleting live compiler work.

Add token-bound UI recovery and real hard-kill coverage for apply, reapply, reset, and cleanup publication.
@dh0er

dh0er commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@dh0er

dh0er commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. 👍

Reviewed commit: ee774c528f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dh0er

dh0er commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@dh0er

dh0er commented Aug 17, 2026

Copy link
Copy Markdown
Owner Author

@cursor review

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit ee774c5. Configure here.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Bravo.

Reviewed commit: ee774c528f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@dh0er
dh0er merged commit db9e7f6 into main Aug 17, 2026
2 checks passed
@dh0er
dh0er deleted the codex/mod-manager-v1-interrupted-apply-recovery branch August 17, 2026 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant