chore: release v0.4.0 - #244
Draft
github-actions[bot] wants to merge 4 commits into
Draft
Conversation
The generated 0.4.0 section listed the six DEFI-2911 stack PRs as raw commit subjects under "Changed", while the hand-written `[Unreleased]` entry describing the same work — the new endpoints, the `TradingAccountForbidden` variant, the `placed_by` / `canceled_by` fields, the grant cooldown, and the backward-compatible-Candid note — sat orphaned below it. Move that entry into 0.4.0 as "Added" and drop the six now-redundant "Changed" lines, so the release notes describe the feature instead of its slices. The `!` markers on #207 / #208 only reflect Candid variant additions to the debug `get_events` endpoint, so keeping the compatibility note matters for readers of the GitHub release. Also remove the emptied `[Unreleased]` headings, which release-plz left below the new section, and move the new link definitions to the footer blocks where the other releases' definitions live. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.
Suppressed comments (2)
libs/types/CHANGELOG.md:8
- The changelog drops the standard
## [Unreleased]section, which is still present in other crate changelogs (e.g.libs/client/CHANGELOG.md:8) and in thegit-clifftemplate (cliff.toml:19). Keeping an Unreleased section at the top helps maintain a consistent changelog structure for future entries.
## [0.4.0] - 2026-08-06
canister/CHANGELOG.md:8
- The changelog drops the standard
## [Unreleased]section, but other changelogs in this repo keep it (e.g.libs/client/CHANGELOG.md:8) and thegit-clifftemplate expects it (cliff.toml:19). Consider keeping an Unreleased section at the top for consistency and to make it clear where new changes should be added.
## [0.4.0] - 2026-08-06
Contributor
Author
|
…fresh release-plz sets `dependencies_update = true`, so the release commit refreshes Cargo.lock across 74 crates, which shifts instruction counts and leaves `canbench_results.yml` stale — failing the benchmark gate. Reverting only Cargo.lock to main's version and re-running canbench returns every benchmark to baseline (max +0.19%, i.e. noise), so the whole delta is dependency-driven and no canister code regressed. The wasm-path bumps behind it are num-bigint 0.4.6 -> 0.4.8 (candid's Nat/Int backend) and ic_principal 0.1.3 -> 0.1.5 (via candid and ic-stable-structures). Net effect is favourable: 4 improvements against 1 regression, median -0.21%. bench_write_events::Settling rises 4.39% (29.38M instructions) while the order-book queries drop 13-23% and get_my_trades 2.66%. Heap and stable-memory usage are unchanged throughout. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Contributor
Benchmark baseline re-persistedThe Isolation — reverting only
Since the lockfile was the only variable and the drift vanished, no canister code regressed. Net effect is favourable — 4 improvements against 1 regression, median −0.21%:
Heap and stable-memory deltas are zero across all 16 benchmarks. A fresh |
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 9 changed files in this pull request and generated no new comments.
Suppressed comments (2)
libs/types/CHANGELOG.md:8
- The changelog no longer has an "Unreleased" section at the top. Other crate changelogs in this repo keep an empty "## [Unreleased]" header (e.g. libs/client/CHANGELOG.md), which makes it easy to accumulate upcoming changes between releases.
## [0.4.0] - 2026-08-06
canister/CHANGELOG.md:8
- The changelog no longer has an "Unreleased" section at the top. Other changelogs in this repo keep an empty "## [Unreleased]" header (e.g. libs/types-internal/CHANGELOG.md), which helps track changes between releases.
## [0.4.0] - 2026-08-06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 New release
oisy_trade_types: 0.3.0 -> 0.4.0 (✓ API compatible changes)oisy_trade_canister: 0.3.0 -> 0.4.0Changelog
oisy_trade_typesoisy_trade_canisterThis PR was generated with release-plz.