refactor(e2e): support delete multiple devices for console - #3512
Open
lim-chris wants to merge 2 commits into
Open
refactor(e2e): support delete multiple devices for console#3512lim-chris wants to merge 2 commits into
lim-chris wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Console (non-cloud) Cypress E2E device deletion coverage to correctly delete a specific device when multiple devices may share the same friendly name, which is important for non-isolated (ISOLATE=N) runs against environments that already contain devices.
Changes:
- Scopes the delete action to the table row containing
Cypress.env('DEVICE')(hostname/IP) to avoid deleting the wrong device when friendly names collide. - Adjusts post-delete assertions to only require the targeted device to be absent, instead of asserting the shared friendly name is gone.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
lim-chris
force-pushed
the
rmmultipledevices
branch
from
August 20, 2026 05:09
cfc7931 to
9b409ac
Compare
choonkeat1986
approved these changes
Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Checklist
What are you changing?
Updated the console E2E delete-device test to support deleting multiple devices in a single flow.
Anything the reviewer should know when reviewing this PR?
If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )