Skip to content

refactor(e2e): support delete multiple devices for console - #3512

Open
lim-chris wants to merge 2 commits into
mainfrom
rmmultipledevices
Open

refactor(e2e): support delete multiple devices for console#3512
lim-chris wants to merge 2 commits into
mainfrom
rmmultipledevices

Conversation

@lim-chris

Copy link
Copy Markdown
Contributor

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Updated the console E2E delete-device test to support deleting multiple devices in a single flow.

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the Console (non-cloud) Cypress E2E device deletion coverage to correctly delete a specific device when multiple devices may share the same friendly name, which is important for non-isolated (ISOLATE=N) runs against environments that already contain devices.

Changes:

  • Scopes the delete action to the table row containing Cypress.env('DEVICE') (hostname/IP) to avoid deleting the wrong device when friendly names collide.
  • Adjusts post-delete assertions to only require the targeted device to be absent, instead of asserting the shared friendly name is gone.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread cypress/e2e/integration/device/delete.spec.ts Outdated

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants