Skip to content

ci(gh-actions): drop node 20 support - #2898

Open
madhavilosetty-intel wants to merge 2 commits into
mainfrom
ci/drop-node-20
Open

ci(gh-actions): drop node 20 support#2898
madhavilosetty-intel wants to merge 2 commits into
mainfrom
ci/drop-node-20

Conversation

@madhavilosetty-intel

Copy link
Copy Markdown
Contributor

Every rps workflow already runs 22 or newer -- the test matrix covers 22 and 24, and release.yml and semantic.yml are both on 24.x -- so Node 20 has not been exercised anywhere for a while. engines.node was the only place still claiming support for it.

Also normalises the matrix entry 24.X to 24.x so it matches the three matrix.node-version == '24.x' conditions literally. Those conditions already worked, because GitHub Actions string comparison is case-insensitive, but the mismatch was confusing and it made the artifact name rps-unit-24.X.

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. device-management-toolkit/repo#365 )

Every rps workflow already runs 22 or newer -- the test matrix covers 22 and 24,
and release.yml and semantic.yml are both on 24.x -- so Node 20 has not been
exercised anywhere for a while. engines.node was the only place still claiming
support for it.

Also normalises the matrix entry 24.X to 24.x so it matches the three
matrix.node-version == '24.x' conditions literally. Those conditions already
worked, because GitHub Actions string comparison is case-insensitive, but the
mismatch was confusing and it made the artifact name rps-unit-24.X.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants