ci: pin release Go version to go.mod - #1250
Merged
Merged
Conversation
setup-go satisfied ">=1.23.0" with the runner's pre-installed Go 1.26.7 and GOTOOLCHAIN=local was in effect, so the release build failed against the go 1.27.0 directive in go.mod. Read the version from go.mod instead, as ci.yml already does, so a future bump of the go directive cannot desync the release job.
madhavilosetty-intel
enabled auto-merge (squash)
September 4, 2026 16:58
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1250 +/- ##
=======================================
Coverage 56.71% 56.71%
=======================================
Files 149 149
Lines 12154 12154
=======================================
Hits 6893 6893
Misses 5260 5260
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
rsdmike
approved these changes
Sep 4, 2026
|
🎉 This PR is included in version 1.40.1 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Member
|
Would recommend to not do this, creates overhead and pins to a specific version in go.mod meaning more frequent updates to the go.mod file. Recommend to simply update constraint to 1.25.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
setup-go satisfied ">=1.23.0" with the runner's pre-installed Go 1.26.7 and GOTOOLCHAIN=local was in effect, so the release build failed against the go 1.27.0 directive in go.mod. Read the version from go.mod instead, as ci.yml already does, so a future bump of the go directive cannot desync the release job.