Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1249 +/- ##
=======================================
Coverage 56.71% 56.71%
=======================================
Files 149 149
Lines 12154 12154
=======================================
Hits 6893 6893
Misses 5260 5260
Partials 1 1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
5286c89 to
b52f925
Compare
Signed-off-by: punam biswal <punam.biswal@intel.com>
There was a problem hiding this comment.
@punam20 Findings only go to the job log — gitleaks.yml:44 has no --report-path, so nothing is persisted. Trivy, CodeQL and Scorecards in this repo all emit SARIF and upload it. Could we do the same here?
commitlint wants a conventional-commit header, on both the commit and the PR title. Please change to something like ci(gh-actions): add gitleaks secret scanning
Minor one on the description — the gitleaks pre-commit hook was already on main at v8.16.3, so this bumps it to v8.30.1. The CI workflow is the new piece. Might be worth wording it that way?
| @@ -0,0 +1,24 @@ | |||
| # Known findings from historical commits that are test-only / example secrets. | |||
| # These cannot be scrubbed without rewriting published git history, so they are | |||
| # allowlisted by fingerprint instead. See CONTRIBUTING.md before adding new entries. | |||
There was a problem hiding this comment.
.gitleaksignore:3 points to CONTRIBUTING.md, though there's no gitleaks section there yet. Was that meant to come along with this, or should the pointer go?
3 participants
Enables gitleaks secret scanning in CI and pre-commit.