Guard legacy controller normalization

[dereuromark]

Make legacy application-controller normalization fail atomically instead of falling through to creation of a duplicate controller row when the update cannot be saved.

The regression test forces the legacy update to fail and verifies that synchronization stops with the original row intact and no null-plugin duplicate. The service documentation now also describes the loaded-plugin ambiguity guard.

Follow-up to #38 and its review findings.

[coderabbitai]

Warning

Review limit reached

@dereuromark, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 55 minutes

Limit details: You’ve used all 1 included review currently available under your plan.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 042fae02-86a2-43c6-b345-319aced15ad5

📥 Commits

Reviewing files that changed from the base of the PR and between 6463098 and b9ee1c9.

📒 Files selected for processing (3)

• docs/reference/services.md
• src/Service/ControllerSyncService.php
• tests/TestCase/Service/ControllerSyncServiceTest.php

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.23%. Comparing base (6463098) to head (b9ee1c9).
⚠️ Report is 1 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff            @@
##             master      #39   +/-   ##
=========================================
  Coverage     82.23%   82.23%           
+ Complexity      601      600    -1     
=========================================
  Files            46       46           
  Lines          2297     2297           
=========================================
  Hits           1889     1889           
  Misses          408      408           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.