btc: Validate TxHash in AuditContract. - #3620
Open
jholdstock wants to merge 1 commit into
Open
Conversation
If AuditContract checks the coinID and the contract but not the transaction hash, it is possible for a malicious server to send a BTC taker a transaction which meets those criteria yet underpays the expected amount. This check was already performed in the DCR asset so the fix for BTC has been modeled on that implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If AuditContract checks the coinID and the contract but not the transaction hash, it is possible for a malicious server to send a taker a transaction which meets those criteria yet underpays the expected amount.
This check was already performed in the DCR asset so the fix for BTC has been modeled on that implementation.