Maintenance: modernize tooling, fix mpdscribble_history import bug - #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR brings several maintenance updates to the project:
Bug Fix
create_network→create_networks(the function was renamed inutils.pybut the import inmpdscribble_history.pywas not updated, causing anImportErrorat runtime).Project Modernization
setup.pyto the modern[project]section (name, version, dependencies, classifiers, scripts, URLs). Added[tool.pytest.ini_options]for test discovery.setup()call, deferring all metadata topyproject.toml.httpx>=0.28.0,python-mpd2>=3.0.0,pylast>=5.0.0). Bumped requires-python to>=3.9.CI & Tooling
actions/checkoutv2→v4,actions/setup-pythonv2→v5,codecov-actionv1→v5. Removed EOL Python 3.7/3.8, added 3.12/3.13.pre-commit-hooksv4.5.0→v5.0.0,black23.3.0→25.1.0,flake86.0.0→7.1.1.pipenv-based shell with modern venv-based approach.__init__.py: Removed unnecessary shebang, encoding declaration, and unusednamevariable.Testing
All 8 existing tests pass with the updated configuration.