Await plugin worker shutdown before settling - #9
Open
datzle123 wants to merge 2 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause
PluginHostsettled timeout/error/success beforeworker.terminate()completed. Windows could still hold the plugin module handle when cleanup removed the fixture, producingENOTEMPTY.Fix
Wait for worker termination before resolving or rejecting the invocation. A termination failure now fails closed with redacted diagnostics.
Evidence
30208423273exposed the Windows Node 20 cleanup race; the new aggregate prerequisite guard failed as intended.