Refactor/perf batch 4#663
Merged
Merged
Conversation
…verage, update guide
…factor/perf-batch-4
StuartWheater
requested review from
StuartWheater
and removed request for
StuartWheater
July 23, 2026 09:26
StuartWheater
approved these changes
Jul 23, 2026
StuartWheater
left a comment
StuartWheater
left a comment
Member
There was a problem hiding this comment.
- Appears to mostly be removing second call to check existence of created object.
- Performance profiles need to be extended to include results for new tests
- Not clear if tests still have same coverage as before
Contributor
Author
I have double checked and no test coverage has been lost. Main changes were:
|
Member
|
If tests pass, will merge new perf-profile into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.