Skip to content

docs(rpc): update core rpcs to 23.1.7#582

Merged
thephez merged 4 commits into
dashpay:23.0.0from
thephez:rpc/v23.1.7-updates
Jul 20, 2026
Merged

docs(rpc): update core rpcs to 23.1.7#582
thephez merged 4 commits into
dashpay:23.0.0from
thephez:rpc/v23.1.7-updates

Conversation

@thephez

@thephez thephez commented Jul 20, 2026

Copy link
Copy Markdown
Collaborator

Updates the Core RPC API reference to Dash Core 23.1.7, capturing new RPCs, result-field additions, and deprecations introduced across the 23.1.x series.

Highlights

  • New RPCs documented: enumeratesigners and walletdisplayaddress (external signer support, new in Dash Core 23.1.0), added to both the wallet reference and the RPC quick reference.
  • Masternode address restructuring: documented the new structured addresses object (core_p2p, platform_p2p, platform_https) across masternode, masternodelist, and protx results, with the flat service, platformP2PPort, and platformHTTPPort fields marked deprecated in 23.0.0.
  • Result/field updates across the blockchain, dash, evo, raw transaction, and wallet RPC pages to match 23.1.7 output.

Preview build: https://dash-docs--582.org.readthedocs.build/en/582/

Summary by CodeRabbit

  • Documentation
    • Added documentation for external-signer wallet workflows, including signer enumeration, address display, and wallet creation options.
    • Documented new wallet balance and wallet information fields for tracking the last processed block.
    • Updated masternode RPCs with structured address information and deprecation notices for legacy fields.
    • Clarified blockchain validity fields in governance RPC responses.
    • Expanded protx listdiff, fundrawtransaction, and transaction response schemas.
    • Added new wallet RPCs to the quick reference and documented inferred output descriptors.

@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@thephez, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: cc38d051-5e97-4839-b0e2-d7832a35bae7

📥 Commits

Reviewing files that changed from the base of the PR and between 73908ba and b07c25d.

📒 Files selected for processing (3)
  • docs/core/api/remote-procedure-calls-dash.md
  • docs/core/api/remote-procedure-calls-wallet.md
  • scripts/core-rpc-tools/dash-cli-help-23.1.7.jsonl
📝 Walkthrough

Walkthrough

The RPC documentation is updated for wallet external-signer functionality, structured masternode addresses, governance validity fields, expanded Evolution schemas, and additional transaction and blockchain response fields.

Changes

RPC documentation

Layer / File(s) Summary
Wallet signer RPC contracts
docs/core/api/remote-procedure-calls-wallet.md, docs/core/api/remote-procedure-call-quick-reference.md
Documents external-signer wallet creation, signer enumeration, signer-confirmed address display, updated wallet response fields, and quick-reference entries for the new RPCs.
Governance and masternode schemas
docs/core/api/remote-procedure-calls-dash.md, docs/core/api/remote-procedure-calls-evo.md
Replaces local governance validity documentation with blockchain validity fields and documents structured masternode address objects, deprecations, and expanded protx listdiff schemas and examples.
Transaction and blockchain response schemas
docs/core/api/remote-procedure-calls-blockchain.md, docs/core/api/remote-procedure-calls-raw-transactions.md
Adds the GetBlock descriptor field, documents fundrawtransaction input size metadata, and corrects decoded transaction values to objects.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the changes: a docs-only update to Core RPC references for Dash Core 23.1.7.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/core/api/remote-procedure-calls-dash.md`:
- Around line 583-592: Update the governance-object field tables in both the
`gobject diff` and `gobject list` sections so `fBlockchainValidity`,
`IsValidReason`, `fCachedValid`, `fCachedFunding`, `fCachedDelete`, and
`fCachedEndorsed` use `→ →` nesting, matching `DataHex`, `Hash`, and the
vote-count fields rather than appearing as direct `Result` members.
- Around line 604-620: Synchronize each documented RPC example with its version
caption: in docs/core/api/remote-procedure-calls-dash.md lines 604-620, update
the gobject diff caption or restore the historical payload; in lines 821-855,
update the gobject list caption or restore its historical payload; and in lines
1753-1809, change the masternodelist caption to Dash Core 23.0.0 or later, or
remove the addresses field. Preserve accurate field availability for every
example.

In `@docs/core/api/remote-procedure-calls-wallet.md`:
- Around line 709-711: Update the response table’s lastprocessedblock, hash, and
height rows so each has the appropriate nesting marker placing them inside the
result object, matching the documented JSON example.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 6312a28a-d582-42c6-9da5-dc8f052d9ffe

📥 Commits

Reviewing files that changed from the base of the PR and between 0ea7b4c and 73908ba.

📒 Files selected for processing (6)
  • docs/core/api/remote-procedure-call-quick-reference.md
  • docs/core/api/remote-procedure-calls-blockchain.md
  • docs/core/api/remote-procedure-calls-dash.md
  • docs/core/api/remote-procedure-calls-evo.md
  • docs/core/api/remote-procedure-calls-raw-transactions.md
  • docs/core/api/remote-procedure-calls-wallet.md

Comment thread docs/core/api/remote-procedure-calls-dash.md Outdated
Comment thread docs/core/api/remote-procedure-calls-dash.md
Comment thread docs/core/api/remote-procedure-calls-wallet.md Outdated
@thephez
thephez merged commit cc92fc0 into dashpay:23.0.0 Jul 20, 2026
1 check passed
@thephez
thephez deleted the rpc/v23.1.7-updates branch July 20, 2026 14:49
@thephez thephez added the RPC label Jul 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant