Skip to content

Migrate passive wallet state UI tail from DashSync - #905

Merged
llbartekll merged 1 commit into
swift-sdk-integration-2from
codex/dashsync-passive-wallet-state-ui-tail
Jul 30, 2026
Merged

Migrate passive wallet state UI tail from DashSync#905
llbartekll merged 1 commit into
swift-sdk-integration-2from
codex/dashsync-passive-wallet-state-ui-tail

Conversation

@llbartekll

Copy link
Copy Markdown

Summary

  • drive Home transaction reload requests from distinct SwiftDashSDK balance changes and remove the redundant BalanceModel legacy observer
  • move Explore faucet/network and Buy/Sell visibility reads to existing app-owned WalletEnvironment and SwiftDashSDK boundaries
  • remove dead passive consumers, add focused regression tests, and update the DashSync migration/teardown docs including the current Watch target dependency

Tests

  • git diff --check
  • plutil -lint DashWallet.xcodeproj/project.pbxproj
  • full DashSync import, DS type, balance-notification, DWEnvironment, Pod/project, source-membership, and forbidden-scope audits
  • dashpay arm64 Simulator build without signing: passed
  • focused DashWalletTests/PassiveWalletStateUITailTests and the dashwallet build are locally blocked before test compilation because the installed Watch simulator runtime 23S303 does not match the Watch SDK runtime 23T570

Scope

No Watch implementation/graph, Podfile, storage/keychain, SDK/platform, Coinbase, CrowdNode, DASHSYNC_KEY_MIGRATION.md, or DWUpholdMainnetConstants.m changes.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 1c4debd5-b7d6-424e-9648-928d962fb7eb

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@llbartekll
llbartekll requested a review from romchornyi July 30, 2026 11:35
@llbartekll
llbartekll changed the base branch from swift-sdk-integration to swift-sdk-integration-2 July 30, 2026 12:14
@llbartekll
llbartekll merged commit eab513f into swift-sdk-integration-2 Jul 30, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant