Skip to content

Remove active Coinbase and Uphold DashSync dependencies - #896

Merged
llbartekll merged 2 commits into
swift-sdk-integrationfrom
codex/dashsync-coinbase-uphold-tail
Jul 29, 2026
Merged

Remove active Coinbase and Uphold DashSync dependencies#896
llbartekll merged 2 commits into
swift-sdk-integrationfrom
codex/dashsync-coinbase-uphold-tail

Conversation

@llbartekll

Copy link
Copy Markdown

Summary

  • add an app-owned KeychainStore based on the existing PinStore implementation while preserving DashSync-compatible service, account names, accessibility, and byte encoding
  • rewire Coinbase, Uphold, DWGlobalOptions, and ExchangeAddressProvider keychain access
  • move all reachable Uphold HTTP operations to the app-owned HTTPClient behind the existing Objective-C facade
  • remove the unused Uphold provider, account model, and dead endpoint chains
  • update migration documentation and keychain golden fixtures

Verification

  • scripts/auth_keychain_goldens/run_goldens.sh
  • plutil -lint DashWallet.xcodeproj/project.pbxproj
  • dashpay Debug arm64 iOS Simulator build
  • dashpay Release device archive with code signing disabled
  • static audit for removed DashSync keychain/HTTP references and dead endpoint callers
  • git diff --check

The dashwallet Debug/Release builds remain blocked by the pre-existing Watch runtime mismatch (23S303 vs SDK 23T570); the same failure is present on the clean base.

Manual smoke test

  • confirm existing Coinbase and Uphold sessions survive upgrade and restart
  • verify Uphold cards and balance
  • buy/withdraw DASH, including OTP retry and commit
  • verify logout/revoke and re-login
  • cancel during re-quote without showing a new error UI

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 28139e35-7663-4799-beff-ba3bcbf46635

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch codex/dashsync-coinbase-uphold-tail

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@llbartekll
llbartekll requested a review from romchornyi July 29, 2026 11:20
@llbartekll
llbartekll marked this pull request as ready for review July 29, 2026 11:20
@llbartekll
llbartekll merged commit 30716c2 into swift-sdk-integration Jul 29, 2026
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants