backport: bitcoin#16807, #21825, #22257, #23577, #24259, #24420, #24339, #24441, #24735, #25125, #25171

[knst]

What was done?

Regular backports from Bitcoin Core v22, v23, v24

How Has This Been Tested?

Run unit & functional tests

Breaking Changes

• remove -deprecatedrpc=exclude_coinbase logic

• The validateaddress RPC now returns an error_locations array for invalid
  addresses, with the indices of invalid character locations in the address (if
  known). For example, this will attempt to locate up to two Bech32 errors, and
  return their locations if successful. Success and correctness are only guaranteed
  if fewer than two substitution errors have been made.
  The error message returned in the error field now also returns more specific
  errors when decoding fails.

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation
• I have assigned this pull request to a milestone

[thepastaclaw]

⛔ Blockers found — Sonnet deferred (commit 1f1bacd)
Canonical validated blockers: 1

[github-actions]

Potential PR merge conflicts

This is advisory only. It does not block CI, but it marks PRs that will likely need a rebase depending on merge order.

If this PR merges first

These open PRs will likely need a rebase:

• #7294: feat: asset lock tx v2 with basic RPC support + tests Changed files: src/rpc/output_script.cpp.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: a3aff447-1644-40ab-848e-76dae099a6b5

📥 Commits

Reviewing files that changed from the base of the PR and between c81f21c and 1f1bacd.

📒 Files selected for processing (16)

• ci/test/00_setup_env_native_valgrind.sh
• ci/test/00_setup_env_s390x.sh
• contrib/valgrind.supp
• doc/bips.md
• doc/release-notes-16807.md
• src/key_io.cpp
• src/key_io.h
• src/rpc/blockchain.cpp
• src/rpc/output_script.cpp
• src/test/fuzz/script_format.cpp
• src/test/versionbits_tests.cpp
• src/wallet/rpc/coins.cpp
• src/wallet/rpc/transactions.cpp
• test/functional/rpc_invalid_address_message.py
• test/functional/rpc_verifyislock.py
• test/functional/wallet_listreceivedby.py

🚧 Files skipped from review as they are similar to previous changes (11)

• ci/test/00_setup_env_s390x.sh
• ci/test/00_setup_env_native_valgrind.sh
• test/functional/rpc_verifyislock.py
• doc/bips.md
• contrib/valgrind.supp
• src/rpc/output_script.cpp
• src/test/fuzz/script_format.cpp
• src/wallet/rpc/coins.cpp
• src/rpc/blockchain.cpp
• test/functional/wallet_listreceivedby.py
• src/wallet/rpc/transactions.cpp

---

Walkthrough

The change expands address decoding diagnostics and adds error_locations to validateaddress, with functional coverage for Bech32, Platform, Base58, and malformed inputs. Wallet received-transaction RPCs remove deprecated exclude_coinbase handling. I2P seed parsing, CI exclusions, Valgrind suppressions, documentation, fuzz bounds, test fixtures, RPC help text, and transaction parsing helpers are also updated.

Estimated code review effort: 4 (Complex) | ~45 minutes

Sequence Diagram(s)

sequenceDiagram
  participant validateaddress
  participant DecodeDestination
  participant LocateErrors
  validateaddress->>DecodeDestination: decode address and collect error locations
  DecodeDestination->>LocateErrors: locate Bech32 errors
  LocateErrors-->>DecodeDestination: error text and indices
  DecodeDestination-->>validateaddress: error and error_locations

Loading

Possibly related PRs

• dashpay/dash#7177: Both changes concern exclusions or behavior related to the feature_init functional test.
• dashpay/dash#7452: Both changes involve bech32::LocateErrors and Bech32 error-location reporting.

Suggested reviewers: udjinm6

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 6.67% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title correctly identifies this as a backport and the referenced PRs match the changeset.
Description check	✅ Passed	The description matches the backported changes and highlights the same breaking RPC updates.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 4

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@contrib/seeds/generate-seeds.py`:
- Line 19: Update the I2P seed format example in the relevant documentation or
generator template from “<i2p>.b32.i2p:<port>” to “<i2p>.b32.i2p:0”, explicitly
reflecting that only port 0 is valid for I2P addresses.
- Around line 56-57: Update the address parsing branch in the seed generator to
recognize the .b32.i2p suffix case-insensitively, matching the core parser’s
behavior and accepting uppercase variants such as .b32.I2P while preserving the
existing base32 decoding logic.

In `@doc/bips.md`:
- Around line 41-42: Update the BIP 157/158 entry so the PR references use one
balanced parenthetical group around both links, removing the extra opening
wrapper before PR `#14121` while preserving all link text and URLs.

In `@test/functional/rpc_verifyislock.py`:
- Line 6: Remove the unused CTransaction symbol from the import statement in
rpc_verifyislock.py, while retaining tx_from_hex, hash256, ser_compact_size, and
ser_string.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: dc0de3bd-8e71-44f6-a9bc-178dbd1237c9

📥 Commits

Reviewing files that changed from the base of the PR and between 585856a and e23d643.

📒 Files selected for processing (18)

• ci/test/00_setup_env_native_valgrind.sh
• ci/test/00_setup_env_s390x.sh
• contrib/seeds/generate-seeds.py
• contrib/valgrind.supp
• doc/bips.md
• doc/release-notes-16807.md
• src/key_io.cpp
• src/key_io.h
• src/rpc/blockchain.cpp
• src/rpc/output_script.cpp
• src/test/fuzz/script_format.cpp
• src/test/versionbits_tests.cpp
• src/wallet/rpc/coins.cpp
• src/wallet/rpc/transactions.cpp
• test/functional/interface_zmq_dash.py
• test/functional/rpc_invalid_address_message.py
• test/functional/rpc_verifyislock.py
• test/functional/wallet_listreceivedby.py

[coderabbitai]

🗄️ Data Integrity & Integration | 🟡 Minor | ⚡ Quick win

Document the I2P port restriction.

<port> implies that arbitrary ports are valid, but I2P addresses are accepted only with port 0; non-zero ports are rejected by src/test/evo_netinfo_tests.cpp. Document this as <i2p>.b32.i2p:0 to avoid generating invalid seed entries.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@contrib/seeds/generate-seeds.py` at line 19, Update the I2P seed format
example in the relevant documentation or generator template from
“<i2p>.b32.i2p:<port>” to “<i2p>.b32.i2p:0”, explicitly reflecting that only
port 0 is valid for I2P addresses.

[coderabbitai]

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Match the core parser’s case-insensitive suffix handling.

This rejects valid addresses such as ...b32.I2P, while src/netaddress.cpp lowercases the suffix and src/test/net_tests.cpp explicitly covers uppercase I2P addresses.

Proposed fix

-    elif addr.endswith('.b32.i2p'):
+    elif addr.lower().endswith('.b32.i2p'):

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change

	elif addr.endswith('.b32.i2p'):
	vchAddr = b32decode(addr[0:-8] + '====', True)
	elif addr.lower().endswith('.b32.i2p'):
	vchAddr = b32decode(addr[0:-8] + '====', True)

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@contrib/seeds/generate-seeds.py` around lines 56 - 57, Update the address
parsing branch in the seed generator to recognize the .b32.i2p suffix
case-insensitively, matching the core parser’s behavior and accepting uppercase
variants such as .b32.I2P while preserving the existing base32 decoding logic.

[chatgpt-codex-connector]

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: e23d643f81

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

[thepastaclaw]

Preliminary review — Codex only

The backport is generally well adapted, but the bitcoin#24259 Valgrind change is incomplete. It removes Ubuntu-20.04-specific suppressions while leaving the Valgrind job on Ubuntu 20.04, which can cause Valgrind reports to fail CI.

Validated blockers were found in the Codex precheck. Sonnet is deferred until a fresh Codex revalidation clears the blocker gate.

Review provenance

• Codex reviewers: gpt-5.6-sol — general (completed), gpt-5.6-sol — dash-core-commit-history (completed), gpt-5.6-sol — backport-reviewer (completed)
• Verifier: gpt-5.6-sol — verifier
• Sonnet: not run (deferred by blocker gate)

🔴 1 blocking

🤖 Prompt for all review comments with AI agents

These findings are from an automated code review. Verify each finding against the current code and only fix it if needed.

In `ci/test/00_setup_env_native_valgrind.sh`:
- [BLOCKING] ci/test/00_setup_env_native_valgrind.sh:8-9: Missing prerequisite hunk: bitcoin#24259's Ubuntu 22.04 Valgrind image
  Upstream commit fa4b61911d54840e9a24bfcabafec159f013ee9a changes this task's image from `ubuntu:20.04` to `ubuntu:22.04` in the same commit that removes the `wcsnrtombs` and Boost suppressions. Dash applied the suppression removals and changed `contrib/valgrind.supp` to document Ubuntu 22.04 as the tested environment, but omitted the image override. `ci/dash/matrix.sh` sources `ci/test/00_setup_env.sh` first, so this task still inherits its `ubuntu:20.04` default. The job therefore runs Ubuntu 20.04 system libraries without their corresponding suppressions, and Valgrind's `--error-exitcode=1` can turn those reports into CI failures. Add the upstream task-specific Ubuntu 22.04 override.

[thepastaclaw]

🔴 Blocking: Missing prerequisite hunk: bitcoin#24259's Ubuntu 22.04 Valgrind image

Upstream commit fa4b619 changes this task's image from ubuntu:20.04 to ubuntu:22.04 in the same commit that removes the wcsnrtombs and Boost suppressions. Dash applied the suppression removals and changed contrib/valgrind.supp to document Ubuntu 22.04 as the tested environment, but omitted the image override. ci/dash/matrix.sh sources ci/test/00_setup_env.sh first, so this task still inherits its ubuntu:20.04 default. The job therefore runs Ubuntu 20.04 system libraries without their corresponding suppressions, and Valgrind's --error-exitcode=1 can turn those reports into CI failures. Add the upstream task-specific Ubuntu 22.04 override.

Suggested change

	export PACKAGES="valgrind clang llvm libclang-rt-dev python3-zmq libevent-dev bsdmainutils libboost-dev libdb5.3++-dev libminiupnpc-dev libzmq3-dev"
	export DOCKER_NAME_TAG="ubuntu:22.04"
	export PACKAGES="valgrind clang llvm libclang-rt-dev python3-zmq libevent-dev bsdmainutils libboost-dev libdb5.3++-dev libminiupnpc-dev libzmq3-dev"

_{source: ['codex']}