feat(deck): smaller icon-style titles, pure-black tiles, reversed layout option, tab-bar label parity - #590
Merged
Merged
Conversation
- Task 4: correct the falsified 'typecheck fixture ripple' (defaultSettings() is the controller callback shape and tests sit outside tsconfig includes; only the StreamDeckSettings renderSection fixture needs keyLayout, at runtime) - Task 4: name both reload-path gates (pickKeys allowlist + normalizer value gate) as individually load-bearing; add a reload-proxy test to Step 1 - Task 8: re-point keyLayout seeding note to the Task 6 DeckStoreOpts dispatch - Tasks 4/5/6 + Global Constraints: document 'newest-first' = strictly reverse tab-bar order (tab reordering is wired via drag/keyboard/context menu and cross-device sync can adopt remote order); name kept deliberately - Task 6: forbid touching deck-controller.ts before Task 7 - Task 8: document known baseline flake in the server test-coordinator integration test + solo-rerun disambiguation - Self-Review Record: add Stage-2 validation addendum (2b)
…sk 6, correct e2e setupLive option name in Task 8 Independent cross-model review (fresheyes iteration 1) found two blocking plan defects: - Task 6 Step 1's fixture migration missed the two frame.test.ts tests that build inline DeckModel literals without the model(n) helper; they now get keyLayout: 'status-sorted' explicitly, with a grep-based completeness check (tests sit outside tsconfig, tsc cannot flag misses). Self-Review 2b's 'migration list is complete' claim removed accordingly. - Task 8's four e2e snippets used a nonexistent setupLive option tabCount; the e2e harness DeckStoreOpts option is tabs (a count, t1..tN). Renamed in all five call sites.
…istic page-preserved outcome (page 2, key 1 -> t3) instead of a reset that cannot fire
…eview stays pinned at 16px
…0% over black (#697d73)
…tTabDisplayTitle 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
…rted), persisted client-side 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
…ed) in Stream Deck settings
…ngeTabs, always-reserved top-left pager plan 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
…ith snapshot-safe press targeting
…ault, live switch, and label parity
…_FONT_SIZE import Final whole-branch review fixes: - Add a pin test: on the Plus under keyLayout 'newest-first', dial 0 cycles the ARRANGED tab list ([t3, t2, t1]) — rotating +1 from active t3 lands on t2, not t1 (which would indicate cycling the un-arranged model order). Test-only; pins already-shipped handleDialRotate behavior. - Remove the dead TITLE_FONT_SIZE import from tile-renderer.test.ts (all uses were converted to literals). 🤖 Generated with [Amplifier](https://github.com/microsoft/amplifier) Co-Authored-By: Amplifier <240397093+microsoft-amplifier@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deck rendering refinements (follow-up to #576/#580/#585). Client-only.
Quality: TDD; plan review passed (clean round-3 verdict); independent delta review passed round 1 with zero blockers (hand-verified mirror-image press math, paging, color math, persistence round-trips); client suite fully green (431 files / 4,718 tests); dial reversed-cycling behavior pinned by test after final review. Two pre-existing server-side timing flakes observed in full runs, each passing in isolation (known-flake follow-up noted, out of scope).