InstallHooks: reconcile copied hooks against registered hooks after apply#1540
Open
tzioup wants to merge 1 commit into
Open
InstallHooks: reconcile copied hooks against registered hooks after apply#1540tzioup wants to merge 1 commit into
tzioup wants to merge 1 commit into
Conversation
…pply Copying the hook scripts and merging hooks.json are two independent operations, each verified on its own. A hook can land on disk without any settings entry naming it, and nothing currently compares the two sets. After --apply, shell the shipped reconciler (Doctor.ts --reconcile, already on disk at this point) and include its unwired list in the install report. Degrades loudly if Doctor.ts is absent rather than skipping silently. On a clean v7.1.1 payload this reports LoopDetector, DriftReminder and PostToolObserver. Refs danielmiessler#1539.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the detection gap in #1539.
What this changes
InstallHooks.tsdoes two independent things and verifies each on its own: itcpSyncs the payloadhooks/tree onto disk (checked by file count), and it mergeshooks.jsonintosettings.json(checked byadded/skipped/events). Both succeed. Nothing compares the set of files copied against the set of hooks registered, so a hook can land on disk with no settings entry naming it and the install still reports success — accurately.After
--apply, this shellsDoctor.ts --reconcile(already on disk at that point, copied by the same install) withCLAUDE_CONFIG_DIRpointed at the target config root, and includes itsunwiredlist in the existing report JSON.No logic is duplicated — the reconciler you shipped in v7.1.1 already does the transitive closure through dispatcher imports correctly. This just asks it.
Behaviour
On a clean v7.1.1 payload into an empty config root:
{ "ok": true, "added": 45, "events": 11, "hookFilesCopied": 72, "unwired": [ "LoopDetector.hook.ts", "DriftReminder.hook.ts", "PostToolObserver.hook.ts" ] }If
Doctor.tsisn't present at that path, the report carries areconcilestring saying so rather than skipping silently — matching the "LOUD blocker, never a silent no-op" rule inWorkflows/Setup.md.Testing
Ran the patched installer against a scratch config root containing only
settings.json({}) andLIFEOS/TOOLS/Doctor.ts, with--skill-rootpointed at this repo'sLifeOS/. Output above is verbatim from that run. Existing report fields are unchanged; the two new keys are additive.Note
unwiredis reported, not enforced — this doesn't fail the install or change exit codes. Happy to make it a blocker instead, or to drop the subprocess and inline the comparison, whichever you'd prefer.