fix(core1): resolve CI stock type error and migrate sale APIs - #7
Open
danielitoCode wants to merge 11 commits into
Open
fix(core1): resolve CI stock type error and migrate sale APIs#7danielitoCode wants to merge 11 commits into
danielitoCode wants to merge 11 commits into
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Qodana for JVM4 new problems were found
View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2025.3.2
with:
upload-result: trueContact Qodana teamContact us at qodana-support@jetbrains.com
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Resolve the Core 1 CI compilation failure and remove the Appwrite Databases deprecation warnings reported by
:shared-data:compileDebugKotlin.Changes
Intquantities to Appwrite'sDouble?API at the infrastructure boundary.Databasesdocument APIs toTablesDBrow APIs.DocumenttoRow.TablesDBwhile preservingDatabasesfor existing consumers.Databasesdocument APIs toTablesDBrow APIs.TablesDBand the sales container injects it..roadmap/Core 1/changes/AgentsLogs.Validation intent
This PR is intentionally against
masterand must be validated by CI before production integration. The previous failure was caused byIntarguments passed to Appwrite atomic operations where the SDK expectsDouble?; the sale API warnings are also addressed.Safety
No direct changes were made to
master. Auto-merge is enabled so GitHub can merge only after the repository's required checks and merge conditions pass.