Skip to content

Apply Openbox 3.6.1 modifications - #49

Open
sbnwl wants to merge 1 commit into
danakj:workfrom
sbnwl:openbox-3.6.1-myPatch
Open

Apply Openbox 3.6.1 modifications#49
sbnwl wants to merge 1 commit into
danakj:workfrom
sbnwl:openbox-3.6.1-myPatch

Conversation

@sbnwl

@sbnwl sbnwl commented Aug 9, 2026

Copy link
Copy Markdown

Overview

This pull request contains a focused set of modifications based on the upstream Openbox source at commit 249020d (July 2015), corresponding to the Openbox 3.6.1 release lineage.

So, these changes are based on upstream commit:

249020d6237bec9abfefc31953e934e83105c91c

The original 3.6.1 source was independently verified against this upstream history, and the five modified source files were transplanted onto that exact upstream base.

Modified files

  • openbox/config.c
  • openbox/frame.c
  • openbox/framerender.c
  • obrender/theme.c
  • obrender/theme.h

Purpose

The modifications primarily address titlebar/frame appearance and geometry, including titlebar button handling and related theme/frame rendering functionality, and includes related titlebar/font/button sizing and positioning changes.

This patch also improves titlebar button usability, particularly on HiDPI displays:

  • Larger, rectangular clickable button area (previously small squares)
  • Button size decoupled from label/font height — Buttons grow with titlebar height
  • Four new button glyph sizes — automatically adapting to 8, 16, 24, 32 px depending on button size
  • Label text size unchanged — no longer needs larger fonts to compensate for HiDPI
  • Verified across multiple themes (Clearlooks, Obworks, Syscrash) and across the range of titlebar heights

Patch structure

The contribution consists of a single commit on top of the historical upstream base:

4f77d6a935814cd70e7185d58d4529d6d17fdc59

The five modified files were verified to match the intended patched source exactly before committing.

This is submitted for upstream review and consideration for future Openbox development.

@sbnwl

sbnwl commented Aug 20, 2026

Copy link
Copy Markdown
Author

The screenshots below compare the titlebar before and after this patch. The patch increases the button click target size for better HiDPI support, while keeping the label text at its original size.

Titlebar button comparison across heights (Clearlooks theme)

Titlebar height Existing Modified
Height 1 (shortest) a2 b2
Height 2 a3 b3
Height 3 a4 b4
Height 4 (tallest) a5 b5

Existing: button size scales with label height only, while padding only increases titlebar height.
Modified: buttons are larger and rectangular, and button size increases with titlebar height.

Reference (obworks theme)

Theme name Existing Modified
obworks theme a1 b1

Here is the Syscrash theme

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant