Survive a build that emits no warnings at all - #12
Merged
Conversation
The gate failed every clean repository, silently. A composite step runs under bash -e -o pipefail, so a grep matching nothing exits 1, the pipeline inherits it, and the step dies before printing anything -- exit code 1 with no output, on exactly the repositories with nothing to report. Both greps are now guarded. The verification that missed this ran the same pipeline through a harness that did not set the shell's flags, so the no-match case passed locally and failed on the first clean repository in CI; the fix is tested by extracting the step's own script and running it under the flags GitHub actually uses, across all five states including the empty one.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The gate failed every clean repository, and failed silently.
A composite step runs under
bash --noprofile --norc -e -o pipefail. Agrepthat matches nothing exits 1,pipefailpropagates it, and-ekills the step before a singleechoruns — so the symptom is exit code 1 with no output, on exactly the repositories that had nothing to report.portfolio-managerwas the first to hit it.Both greps are now guarded with
|| true.How it got through
The verification I ran before merging exercised the same pipeline, in four states, against real build logs — but through a harness script that did not set the shell flags GitHub uses. The no-match case passed there and could only fail in CI.
The fix is tested by extracting the step's own
run:block out of the action and executing it underbash -e -o pipefail, across five states:readme-surface-checkswas audited for the same class of bug and is already guarded throughout.