security fixes and version bumps: - #87
Closed
figulusproject wants to merge 4 commits into
Closed
Conversation
- update lockfile from v1 to v3 - update glob from 7 to ^12 (fixes 2 high severity vulnerabilities) - update underscore from ^1.12.1 to ^1.13.7 (fixes high severity vulnerability) - update postinstall.js to use globSync (required after updating glob version) - version++
- pin node-addon-api to ^2.0.0 (was "*", which resolved to a version requiring C++17's <string_view>, unsupported by the VS2015/MSBuild 14.0 toolchain used in CI) - update package-lock.json
- move NODE_API_MODULE out of the NodeCld namespace (VS2015's non-conformant name lookup misresolves the macro's internal Napi::RegisterModule call as a member of NodeCld::Napi, causing error C2039) - add using NodeCld::Init declaration since NODE_API_MODULE token-pastes its argument and can't take a qualified name
- no glob release fixes the brace-expansion DoS advisory (GHSA-mh99-v99m-4gvg) while supporting Node <20, and glob@^12 itself requires "20 || >=22" - drop Node 8/10/12 from the AppVeyor test matrix - bump os to Visual Studio 2022 (VS2015/MSBuild 14.0 lacks the C++17 support Node 20/22 addon builds need) - bump package.json engines to "20 || >=22" - update package-lock.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Superseded by #88 to correct branch naming issue due to increased scope