Avoid LossySetitemError on pandas >= 3.0 - #368
Open
marksteward wants to merge 1 commit into
Open
Conversation
marksteward
marked this pull request as draft
June 28, 2026 01:17
There was a problem hiding this comment.
Pull request overview
This PR updates LAS color downscaling logic to avoid pandas (>= 3.0) raising LossySetitemError when dividing unsigned-integer DataFrame columns via .loc, by switching to integer (floor) division during uint16 → uint8 conversion.
Changes:
- Replace
/= 256with//= 256when scaling 16-bit color channels down to 8-bit. - Keep the existing guard that avoids scaling when values already fit within
[0, 255].
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pandas 3.0 gets upset at assigning float-like values to a uint column when using
.loc:I've replaced this with an explicit integer division.