Deploy docs through AWS OIDC - #307
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
d2lang-docs-deployAWS role instead of using static AWS access-key secretspublic-readobject ACLWhy
The D2 docs deployment needs to move from Terrastruct-owned AWS credentials and infrastructure to the personally owned D2 AWS stack. The new S3 bucket uses private CloudFront origin access, so object-level public ACLs are neither needed nor accepted.
Impact
After this is merged, successful pushes to
masterwill deploy the docs build tos3://d2lang-docs-278852893615and invalidate CloudFront distributionE2NLB7I775SAFusing short-lived OIDC credentials. This PR does not change production DNS and does not deploy from the PR branch.Validation
.github/workflows/ci.ymlwith Ruby YAMLbash -n ci/deploy.shgit diff --checkd2lang/d2-docsrepository identity onmaster