feat(a11y): full WCAG 2.2 AA accessibility audit — 32 E2E tests - #536
Closed
d-oit wants to merge 4 commits into
Closed
feat(a11y): full WCAG 2.2 AA accessibility audit — 32 E2E tests#536d-oit wants to merge 4 commits into
d-oit wants to merge 4 commits into
Conversation
…s 5 dimensions - Upgrade axe-core helper to fail on critical+serious violations with wcag22aa tags - Add keyboard navigation tests: skip-nav, focus trap, radiogroup arrows, overlay Escape - Add zoom/reflow tests: 200% text zoom, 400% reflow, zoom+mobile - Add automated 44x44px touch-target verification across all views - Add Saffron accent color contrast ratio tests - Fix skip-nav pattern: add tabindex=-1 to main element - Exclude visually-hidden elements from touch-target scans Covers Plan 071 G5.5: fresh accessibility evidence for keyboard, semantics, contrast, zoom, reflow, and target size.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
github-actions
Bot
added
documentation
Contributor
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 11 |
| Duplication | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
…ocus, overlay restore Touch targets (44x44 minimum): - sidebar.tsx: all nav buttons, search, theme/shortcuts/panel toggles - topbar.tsx: hamburger, search, new entity, CMD+K chip - home-view.tsx: CTA buttons, view all link, CompactStat buttons - library-view.tsx: filter chips, grid/list toggles, sort controls, clear button Keyboard accessibility: - editor-view.tsx: radiogroup arrow keys now move focus (WAI-ARIA pattern) - shared-primitives.tsx: Overlay focus restore on unmount (fixes CommandPalette, ResetConfirmDialog) Test fix: - zoom-reflow.spec.ts: removed false-positive h1 visibility assertion at 400% zoom
- mobile-drawer.tsx: nav buttons, close button, search mode toggles, theme toggle all get min-h-[44px] - topbar.tsx: New entity button gets min-w-[44px]
…for contrast - right-panel.tsx: entity type labels, tags, descriptions, metadata upgraded from text-ink-faint/text-ink-mute to text-ink-mute/text-ink - library-view.tsx: entity type labels, tags, counts, dates, descriptions upgraded for contrast - NOTE: computed colors still lighter than CSS values due to pre-existing CSS variable/theme issue — color-contrast violations may persist until theme is fixed
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tabindex=-1to<main>for proper focus movementWhat's tested
accessibility.spec.tskeyboard-a11y.spec.tszoom-reflow.spec.tstouch-targets.spec.tsaccessibility.spec.tsVerification
App bugs exposed by tests (follow-up tasks)
Covers Plan 071 G5.5: fresh accessibility evidence for keyboard, semantics, contrast, zoom, reflow, and target size.