Pipeline runs are ship.build#99
Merged
Merged
Conversation
The rename revision swapped the kind prefix, so build.build_workflow became ship.build_workflow — but the workflow class is Build now, and its kind is ship.build. Nothing matches the old spelling: a pre-rename run falls out of its subject's timeline, and a PR merging on one finds no parked run to cancel.
czpython
enabled auto-merge (squash)
July 26, 2026 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #89.
That revision rewrote
durable_runs.kindwith a prefix swap,'ship.' || substring(kind from 7). The pipeline's old kind wasbuild.build_workflow— classBuildWorkflow, snake-cased — so it becameship.build_workflow. But the class isBuildnow, so its kind isship.build, and nothing matches the migrated spelling. (build.profile→ship.profilewas correct; only the pipeline rows are wrong.)Where it shows:
Run.list_for_subject(..., kind=cls.kind)filterswhere(cls.kind == kind), so a pre-rename run drops out of its subject's timeline and off the board.get_subject_status(..., kind=Build.kind)inWorkItem— a PR merging on a pre-rename work item finds no parked run to cancel.This revision lands both spellings on the real kind, so it is correct whether or not #89's revision has already been applied. The downgrade restores
ship.build_workflow, which #89's own downgrade then maps back tobuild.build_workflow.Not covered here:
dbos.workflow_status.namestill holds the pre-rename registered name for runs that were in flight at deploy. We never read that column, so history is unaffected — it only matters for recovering a run that was PENDING or ENQUEUED across the deploy, which a drain window covers.