The bundled extension is ship, and it lives under druks.contrib#89
Open
czpython wants to merge 1 commit into
Open
The bundled extension is ship, and it lives under druks.contrib#89czpython wants to merge 1 commit into
czpython wants to merge 1 commit into
Conversation
build was the platform's only package that was really an app: druks/build sat beside druks/durable and druks/events as if it were platform. It moves to druks/contrib/ship, so the import path says which layer a module belongs to, and the extension takes the name the product uses. The Build workflow keeps its name inside the app — it is still a build — but its durable kind is now ship.build, and one revision rewrites the kinds and settings keys already in Postgres.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
buildwas the platform's only package that was really an app:druks/buildsat besidedruks/durableanddruks/eventsas if it were platform. It moves todruks/contrib/ship, so the import path says which layer a module belongs to, and the extension takes the name the product uses.druks.build→druks.contrib.ship; extension classBuild→Ship,name = "ship"; entry pointship = "druks.contrib.ship.extension:Ship".BuildWorkflowclass becomesBuild— inside the app it is still a build — so its durable kind isship.buildand the profiler's isship.profile.BuildWorkspace,BuildJournal,BuildPromptContexthang off that workflow and keep their names.templates/prompts/ship/, withbuild_workflow/flattened tobuild/; names areship/build/*.md, so a repo override lives at.druks/ship/prompts/build/*.md./buildto/ship.druks.contribnamespace instead of one extension.settings_overrides.keyextension:build:→extension:ship:, anddurable_runs.kindbuild.%→ship.%.Verified: ruff check, ruff format --check, pyright (135 errors, unchanged from main), pytest --collect-only (959 collected), frontend vitest (51 passed).