FWBUG-1471 frame.c: frame_hdrs_get returns -1 as size_t on allocation…#6
Merged
cj-linas-nenorta merged 1 commit intoJul 17, 2026
Conversation
… failure Description: Return type is `size_t` (unsigned) but the function returns `-1` on realloc failure, which becomes `SIZE_MAX`. Callers iterating over headers will read far out of bounds. Recommendation: Change return type to `ssize_t`, or return `0` with `*hdrs = NULL` on failure. Following the recommended solution from ticket.
There was a problem hiding this comment.
Pull request overview
Addresses FWBUG-1471 by fixing an error-path contract bug in frame_hdrs_get() where returning -1 from a size_t function could become SIZE_MAX, causing callers iterating headers to read out of bounds.
Changes:
- On
stomp_realloc()failure inframe_hdrs_get(), return0and set*hdrs = NULLinstead of returning-1(assize_t).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
cj-linas-nenorta
deleted the
sampsa/fwbug-1471_frame_hdrs_get_returns_minus1
branch
July 17, 2026 10:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… failure
Description: Return type is
size_t(unsigned) but the function returns-1on realloc failure, which becomesSIZE_MAX. Callers iterating over headers will read far out of bounds.Recommendation: Change return type to
ssize_t, or return0with*hdrs = NULLon failure.Following the recommended solution from ticket.