Replace ANSI handling library - #562
Merged
Merged
Conversation
Deploying react-components with
|
| Latest commit: |
08e4901
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a000f7b9.react-components-9pg.pages.dev |
| Branch Preview URL: | https://ansi-to-html-workaround.react-components-9pg.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
Replace
ansi-to-htmlwithansi_up.⚡️ What's your motivation?
ansi-to-htmlwas unmaintained, and bundler changes are starting to cause issues with it e.g. cucumber/html-formatter#540 where webpack's changed wrapping of CommonJS-exported functions broke our usage.ansi_updoesn't have this issue. It also automatically sanitises the input text for XSS, which our old code implied it did, but didn't.🏷️ What kind of change is this?
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.