[Dart] Update lint config to be stricter & resolve new violations - #516
Open
Fried-man wants to merge 5 commits into
Open
[Dart] Update lint config to be stricter & resolve new violations#516Fried-man wants to merge 5 commits into
Fried-man wants to merge 5 commits into
Conversation
…ive linter settings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
dart\analysis_options.yamlto have the content of very_good_analysis' configuration for Dart 3.7 (analysis_options.8.0.0.yaml) & added an ignore for generated dart source.dart fix --applyto automatically apply known lint resolutions to the code.⚡️ What's your motivation?
Per @olexale's comment, the linter configuration we currently have is quite relaxed. In order to drive community adoption of
cucumber_messages& improve code quality, the linter has been updated to reflect the contents of the most popular non-google lint configuration.Previously, @mpkorstanje cited, in a pr review comment, that we should not introduce an additional dependency for the linter. This solution allows for no new dependency to be introduced, the linter to be significantly stricter, and for this repo to have explicit control over the analyzer configuration.
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Feedback on if this is the right approach.
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.