Skip to content

[Dart] Update lint config to be stricter & resolve new violations - #516

Open
Fried-man wants to merge 5 commits into
cucumber:mainfrom
Fried-man:feature/rework-analyzer
Open

[Dart] Update lint config to be stricter & resolve new violations#516
Fried-man wants to merge 5 commits into
cucumber:mainfrom
Fried-man:feature/rework-analyzer

Conversation

@Fried-man

@Fried-man Fried-man commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

🤔 What's changed?

  • I updated dart\analysis_options.yaml to have the content of very_good_analysis' configuration for Dart 3.7 (analysis_options.8.0.0.yaml) & added an ignore for generated dart source.
  • I ran dart fix --apply to automatically apply known lint resolutions to the code.
  • I updated the example's output from print to standard out to satisfy the newly found lint violation.

⚡️ What's your motivation?

Per @olexale's comment, the linter configuration we currently have is quite relaxed. In order to drive community adoption of cucumber_messages & improve code quality, the linter has been updated to reflect the contents of the most popular non-google lint configuration.

Previously, @mpkorstanje cited, in a pr review comment, that we should not introduce an additional dependency for the linter. This solution allows for no new dependency to be introduced, the linter to be significantly stricter, and for this repo to have explicit control over the analyzer configuration.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

♻️ Anything particular you want feedback on?

Feedback on if this is the right approach.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@Fried-man Fried-man changed the title [Dart] Update lint config to be stricter [Dart] Update lint config to be stricter & resolve new violations Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant