Skip to content

[cpp] Refactor codegen, use shared_ptr for messages, renamed classes for consistency with other languages - #473

Draft
daantimmer wants to merge 54 commits into
mainfrom
cpp-breaking-change-use-shared_ptrs-for-messages
Draft

[cpp] Refactor codegen, use shared_ptr for messages, renamed classes for consistency with other languages#473
daantimmer wants to merge 54 commits into
mainfrom
cpp-breaking-change-use-shared_ptrs-for-messages

Conversation

@daantimmer

@daantimmer daantimmer commented Jul 3, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

🤔 What's changed?

  • codegen has been updated with the following changes: (See note)
    • removed the need for the camelize function..
    • all messages referencing/consisting of other messages are now storing them as a std::shared_ptr, this is an important feature enabler for proper implementation of cucumber/query/cpp
  • tests have been updated to test
    • nlohmann/json.hpp should not be included in the public headers
  • added naming conventions to clang-tidy

⚡️ What's your motivation?

The change to shared_ptr is a required change for creating cucumber/query's CPP implementation. This is a breaking change for all projects depending on cucumber/messages/cpp.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • ⚡ New feature (non-breaking change which adds new behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

daantimmer and others added 23 commits July 1, 2026 06:33
@daantimmer
update c++ enum template
73845a0
@daantimmer
update all.hpp, sort all values and use an include guard
1cf49ec
@daantimmer
begin adding support for shared_ptrs
20bb219
@daantimmer
revert codegen to use to_json (and from_json), however, simplified te…
e97715f 
…mplate utility functions
@daantimmer
Add unit tests to test against testdata
ea7e182
@daantimmer
update codegen to remove test for shared_ptrs
34a7066
@daantimmer
refactored utils.hpp to_string to remove complexity
4b6b2f6
@daantimmer
Reorder include statements for consistency in TestMessages.cpp
712b4ae
@daantimmer
Update CMake presets and GitHub Actions for coverage support
a64e4b7
@daantimmer
add host and test workflow
223527b
@daantimmer
remove unused setting from devcontainer.json
cfb9a6c
@daantimmer
undone test change
50bb820
@daantimmer
update changelog.md
607b795
@daantimmer
add support for additional Ubuntu 26.04 configurations in CI workflow
4166f38
@daantimmer
force runs of checks
7d5276b
@mpkorstanje
Merge remote-tracking branch 'origin/main' into refactor-cpp-codegen
a75debc
@daantimmer
remove main.cpp and associated JSON serialization code
e1e6354
@daantimmer
fix make clean
a8abd2c
@daantimmer
add CONTRIBUTING.md for the CPP langauge
3f522f5
@daantimmer
enforce system header properties for nlohmann_json and googletest
2481f7b
@daantimmer
include nlohmann/json_fwd.hpp in generated source files
fa1e20f
@daantimmer
Update changelog
0a1d306
@daantimmer
Merge branch 'main' into refactor-cpp-codegen
c34b8cf
@daantimmer daantimmer changed the title Cpp breaking change use shared ptrs for messages [cpp] Refactor codegen, use shared_ptr for messages, renamed classes for consistency with other languages Jul 3, 2026
@daantimmer
daantimmer changed the base branch from refactor-cpp-codegen to main July 3, 2026 10:53
@daantimmer daantimmer mentioned this pull request Jul 6, 2026
Merged
7 tasks
@daantimmer
daantimmer force-pushed the cpp-breaking-change-use-shared_ptrs-for-messages branch 3 times, most recently from 67ee586 to fd37c6c Compare July 7, 2026 14:51
daantimmer and others added 20 commits July 8, 2026 12:29
@daantimmer
Merge branch 'main' into cpp-breaking-change-use-shared_ptrs-for-mess…
5a41a7f 
…ages
@daantimmer
removed superfluous Generated code comment
e724f14
@daantimmer
fix changelog
5158f52
@daantimmer
Implement DurationUtil for timestamp operations and add corresponding…
e13c029 
… tests
@daantimmer
removed designated initializers
58c3ef1
@daantimmer
removed incorrect install directory entry
01e8452
@daantimmer
use conan as dependency manager (#511)
00429da 
* use conan as dependency manager

* run on all branches

* setup correct actions/setup-python

* refactor: update CMake presets and workflow for Conan integration

* reconfigure conan settings and CI setup

* fix C++ version setting

* pin run-vcpkg to sha

* fix vcpkg

* fix packages-macos

* fix conan unix installation steps

* get conan builds working

* update conan commands to build with C++17 and propagate C++17 requirement in CMake

* update CMake command to use Ninja generator for build process

* cleanup ci

* fix codeql
@daantimmer
rename codeql step
e6dbf53
@daantimmer
fix whitespace
9333660
@daantimmer
Merge branch 'main' into cpp-breaking-change-use-shared_ptrs-for-mess…
5ee4ed4 
…ages
@daantimmer
fix: update display name for test-conan preset
c8b4d42
@daantimmer
update conanfile exports_sources
eebd9f2
@daantimmer
Update CMake configuration and ignore compile_commands.json
3a7c924 
- Change CompilationDatabase path in .clangd to current directory
- Add compile_commands.json to .gitignore
- Create custom target for clangd compile commands in CMakeLists.txt
- Update find_package for nlohmann_json and cucumber_messages
@daantimmer
Update CMakePresets.json to set build type to Debug for host-system a…
8cd6cac 
…nd host-conan presets
@daantimmer
Remove clangd and supporting code
2649c7b
@daantimmer
Remove version dependency for nlohmann_json's find_package
b92810f
@daantimmer
add missing duration addition
e85a9ea
@daantimmer
remove references to conan
e58a95b
@daantimmer
remove conan file
6e27a73
@daantimmer
remove conan_provider
25b086c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@daantimmer @mpkorstanje