Skip to content

[cpp] Add automated tests based on testdata, simplify template usage. - #462

Merged
daantimmer merged 25 commits into
mainfrom
refactor-cpp-codegen
Jul 8, 2026
Merged

[cpp] Add automated tests based on testdata, simplify template usage.#462
daantimmer merged 25 commits into
mainfrom
refactor-cpp-codegen

Conversation

@daantimmer

@daantimmer daantimmer commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

🤔 What's changed?

  • Added deserialization code generation
  • Added unit tests based on testdata
  • Made code adhere to codestyle
  • Added additional compilers to test against
  • I've simplified the template usage in util.hpp to make it more maintainable

⚡️ What's your motivation?

There were no tests and for that we need to be able to deserialize json objects to envelopes/messages. And the template usage was, written in a smart manner, but not really SOLID and extensible.

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I have added/updated tests to cover my changes.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@daantimmer
daantimmer changed the base branch from cpp-remove-cmate-use-native-cmake-and-CPM to main June 30, 2026 21:53
@daantimmer
daantimmer marked this pull request as ready for review June 30, 2026 21:54
@daantimmer
daantimmer changed the base branch from main to cpp-remove-cmate-use-native-cmake-and-CPM June 30, 2026 22:01
Base automatically changed from cpp-remove-cmate-use-native-cmake-and-CPM to main June 30, 2026 22:38
@mpkorstanje
mpkorstanje marked this pull request as draft June 30, 2026 22:38
@daantimmer
daantimmer force-pushed the refactor-cpp-codegen branch from 2c162da to 7d5276b Compare July 1, 2026 06:33
@daantimmer
daantimmer marked this pull request as ready for review July 1, 2026 06:34
@mpkorstanje
mpkorstanje self-requested a review July 1, 2026 10:01
Comment thread cpp/lib/main.cpp Outdated
Comment thread .github/workflows/test-cpp.yml
@mpkorstanje
mpkorstanje marked this pull request as draft July 1, 2026 10:25
@daantimmer
daantimmer marked this pull request as ready for review July 2, 2026 22:19
@daantimmer
daantimmer requested a review from mpkorstanje July 3, 2026 08:27
@daantimmer
daantimmer merged commit a24cb8d into main Jul 8, 2026
65 checks passed
@daantimmer
daantimmer deleted the refactor-cpp-codegen branch July 8, 2026 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants