Duplicate CiEnvironment consistently - #363
Merged
Merged
Conversation
mpkorstanje
force-pushed
the
ruby/include-ci-environment
branch
from
July 22, 2026 10:12
2295528 to
b2198c8
Compare
mpkorstanje
force-pushed
the
ruby/include-ci-environment
branch
from
July 22, 2026 10:27
6e5b0d6 to
a00c490
Compare
mpkorstanje
commented
Jul 22, 2026
| "lint": "biome check --error-on-warnings", | ||
| "postbuild": "node -e \"require('.')\"", | ||
| "generate-ci-environments-ts": "shx cat CiEnvironments.ts.header ../CiEnvironments.json > src/CiEnvironments.ts && biome check --fix --error-on-warnings src/CiEnvironments.ts" | ||
| "generate-ci-environments-ts": "shx cat CiEnvironments.ts.header ../CiEnvironments.json > src/CiEnvironments.ts && biome check --fix --error-on-warnings --vcs-use-ignore-file false src/CiEnvironments.ts" |
Member
Author
There was a problem hiding this comment.
@davidjgoss would it make sense to do this during prepare operation instead? Then the file is generated on npm install and npm publish. It should be available during npm test.
luke-hill
approved these changes
Jul 22, 2026
7 tasks
Contributor
|
@mpkorstanje I've merged in something which also fixes it (just for ruby), but also does some refactors. So there may be some minor conflicts as/when merging in |
mpkorstanje
changed the title
mpkorstanje
changed the title
mpkorstanje
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
CiEnvironment.jsonwas missing from Ruby (#364). Rebuild the process to ensure a similar mistake doesn't happen again.This means:
CiEnvironment.jsonwith MakepretestandprepublishOnlyCiEnvironment.jsonwith MakeCiEnvironment.jsonwith MakeNote that files copied or generated with Make are checked in. Files generated as part of a languages build process are not.
🏷️ What kind of change is this?
📋 Checklist: