build: bump pinned nixpkgs channel from nixos-25.11 to nixos-26.05 - #1108
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (8)
📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
📝 WalkthroughWalkthroughThe changes update lint and Nix tooling configuration, simplify field path formatting, modernize reflection checks, and centralize the managed-resource metric label constant. ChangesRuntime consistency updates
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
The nixos-25.11 channel reached end of life on 2026-06-30 and its branch has not moved since, so every tool pinned through it is frozen. Renovate fails to make this change itself, possibly because of renovatebot/renovate#45000. This commit points the nixpkgs input at nixos-26.05 and refreshes only that input, leaving nixpkgs-unstable and gomod2nix alone. Moving the channel moves the whole toolchain, which accounts for the rest of the diff. protoc-gen-go 1.36.10 to 1.36.11 and protoc-gen-go-grpc 1.5.1 to 1.6.2 regenerate the protobuf output. golangci-lint 2.6.2 to 2.12.2 reports new findings from goconst. It now ignores tests, which stops occurrences there inflating its counts, and pkg/xcrd is excluded because its OpenAPI schema literals read better inline than behind constants. The remaining finding is addressed in place. The new toolchain also prints two deprecation warnings, both cleared here. nixpkgs 26.05 aliases nixfmt-rfc-style to nixfmt, so now we just use nixfmt directly. golangci-lint deprecates gomodguard in favour of gomodguard_v2, which default: all already enables, so the deprecated linter joins the disable list. Signed-off-by: Jared Watts <jbw976@gmail.com>
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-2.2
git worktree add -d .worktree/backport-1108-to-release-2.2 origin/release-2.2
cd .worktree/backport-1108-to-release-2.2
git switch --create backport-1108-to-release-2.2
git cherry-pick -x 973456b6c2cb63460ca70e9796ac6093669cb9c5 |
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin release-2.3
git worktree add -d .worktree/backport-1108-to-release-2.3 origin/release-2.3
cd .worktree/backport-1108-to-release-2.3
git switch --create backport-1108-to-release-2.3
git cherry-pick -x 973456b6c2cb63460ca70e9796ac6093669cb9c5 |
Description of your changes
This PR makes the same bump to
nixos-26.05that crossplane/crossplane#7715 does and then follows the same conventions to make updates and handle the fall out from tool bumps that come along with the nixos bump, e.g. updated linters.The details in crossplane/crossplane#7715 apply here too 🤓
I have:
./nix.sh flake checkto ensure this PR is ready for review.Linked a PR or a docs tracking issue to document this change.backport release-x.ylabels to auto-backport this PR.Need help with this checklist? See the cheat sheet.